-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: fastapi-framework init profile and extension #1868
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Assuming the extension works, this looks good to me.
@lengau, do you typically write spread tests for extensions in charmcraft?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch @mr-cal!
@javierdelapuente could you modify tests/spread/commands/init-flask-framework to test this?
As a rough step-by-step:
- Rename the directory to
init-extensions
- Create
flask
andfastapi
variants, setting thePROFILE
environment variable to the relevant profile - Change the
charmcraft init
command to use--profile ${PROFILE}
@lengau!, I have done it that way for all the missing frameworks (also go). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, thank you!
This PR implements the spec ISD160 - 12-Factor FastAPI Support" for charmcraft.
For that, a new init profile called "fastapi-framework" and a new fastapi extension, called "fastapi-framework" are needed. These additions are similar to the flask and django init profiles and extensions.
For the fastapi profile, the base 24.04 is used.