fix: properly request docker images from docker API #1854
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Command: charmcraft upload-resource blackbox-exporter-k8s blackbox-exporter-image --image="docker://quay.io/prometheus/blackbox-exporter:v0.24.0" --format=json |
lengau
force-pushed
the
work/1760/images
branch
from
f0403dc to
5db9ae4
Compare
|
Thanks @lucabello! I tested it with this case and it failed, but I've modified the PR and added a fix that worked for me locally. Could you test it from the |
|
Confirmed it works from your branch ( |
mr-cal
approved these changes
Aug 30, 2024
lengau
force-pushed
the
work/1760/images
branch
from
7d82a4a to
5912e45
Compare
lengau
commented
Sep 10, 2024
tigarmo
reviewed
Sep 10, 2024
tigarmo
approved these changes
Sep 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1760, reverts #1761
CRAFT-3148