feat: go-framework init profile and extension #1800
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
javierdelapuente
force-pushed
the
go-extension
branch
2 times, most recently
from
4acc1a3 to
4b1d658
Compare
javierdelapuente
changed the title
javierdelapuente
force-pushed
the
go-extension
branch
from
4b1d658 to
9903385
Compare
javierdelapuente
force-pushed
the
go-extension
branch
2 times, most recently
from
2a60cc7 to
6feef2c
Compare
javierdelapuente
changed the title
javierdelapuente
changed the title
javierdelapuente
changed the title
lengau
reviewed
Aug 16, 2024
lengau
reviewed
Aug 16, 2024
lengau
reviewed
Aug 16, 2024
javierdelapuente
force-pushed
the
go-extension
branch
from
36dfed6 to
3ae1311
Compare
javierdelapuente
force-pushed
the
go-extension
branch
from
9fbe6a8 to
4e263b7
Compare
jdkandersson
approved these changes
Aug 20, 2024
1 task
tigarmo
approved these changes
Aug 27, 2024
tigarmo
requested changes
Aug 27, 2024
Corrected to base 24.04 for go and commented all platforms except amd64 |
| arm64: | ||
| ppc64el: | ||
| s390x: | ||
| # arm64: |
There was a problem hiding this comment.
Perhaps include a note explaining what should be done including which command to run to check the architecture, e.g., uname -m and how to interpret the command output?
There was a problem hiding this comment.
Sure. Added comment with dpkg --print-architecture command, as that is the one giving the correct name (debian architecture names are used)
There was a problem hiding this comment.
Sure. Added comment with dpkg --print-architecture command, as that is the one giving the correct name (debian architecture names are used)
tigarmo
approved these changes
Aug 27, 2024
jdkandersson
approved these changes
Aug 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements the spec ISD153, "12-Factor Go Support" for charmcraft.
For that, a new init profile called "go-framework" and a new go extension, called "go-framework" are needed. These additions are similar to the flask and django init profiles and extensions.
For the Go profile, the base 24.04 is used.
Code in extensions is refactored, so all 12 factor extensions, that are similar, inherit from _TwelveFactorBase.