charmcraft publish-lib exits with 0 even if publishing fails

[lucabello]

Bug Description

Currently charmcraft publish-lib correctly fails the library push if something's wrong with LIBPATCH (e.g., LIBPATCH is not bumped, going back, etc). However, the exit of the command is always 0.

This is a problem especially in CI, where a "publish libraries" step will never fail (because of the 0 exit code), and thus is undetectable.

To Reproduce

1. Take a charm library of any charm you own
2. Modify the LIBPATCH to LIBPATCH-1
3. Run charmcraft publish-lib on that library
4. Read the failure message and check the exit code (it will be 0)

Environment

charmcraft 3.2.2.post72+g3a094837 (3.x/edge) (but you can reproduce this with any version)

charmcraft.yaml

-

Relevant log output

-

[syncronize-issues-to-jira]

Thank you for reporting us your feedback!

The internal ticket has been created: https://warthogs.atlassian.net/browse/CRAFT-3830.

This message was autogenerated

[lucabello]

Hey @lengau, if we try to publish-lib a library that's already been published we're getting failures because the return code is 1.

A few options we thought about:

• if the library matches what is in CharmHub, return 0 (because it's not really a failure, it's more of a confirmation);
• return a different error code, so we can differentiate between this "error" and others (actual failure to upload a lib);
• add an arg to publish-lib --dont-fail-if-already-updated (or possibly a more reasonable name :D) to avoid returning 1 in this situation.

[lengau]

@lucabello Ahh yes - it shouldn't be erroring out if you're trying to republish the same version with the same content. That should be considered a no-op, but successful.