Add basic charm functionality and utilities #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kelkawi-a
requested review from
gtato,
onurmus,
mertalpt,
AmberCharitos,
maabujayyab and
kian99
AmberCharitos
approved these changes
May 25, 2024
| self.framework.observe(self.on.config_changed, self._on_config_changed) | ||
| self._state = State(self.app, lambda: self.model.get_relation("peer")) | ||
|
|
||
| self.name = "airbyte-webapp" |
There was a problem hiding this comment.
self.app.name is the name that the user has deployed the application with, which could vary. Fixing the name of the container to airbye-webapp would be more suitable to have uniform instructions on accessing the container.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds basic functionality to the Airbyte UI charm:
Note: Some links point to pages in the Airbyte Charmhub page and server repo which may not exist yet.