logStack include component instantiation mutations #360
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phillipskevin
requested changes
Sep 16, 2019
test/component-can-bind-test.js
Outdated
|
|
||
| new ComponentConstructor({ | ||
| viewModel : { | ||
| foo: value.bind(this,"bar") |
There was a problem hiding this comment.
Does this need to use can-value?
can-component.js
Outdated
|
|
||
| //!steal-remove-start | ||
| if (process.env.NODE_ENV !== 'production') { | ||
| Object.defineProperty(setupFn, "name",{ |
There was a problem hiding this comment.
Is this name needed?
can-component.js
Outdated
| }); | ||
|
|
||
| setupFn = queues.runAsTask(setupFn, function(el, componentTagData) { | ||
| return ["Rendering", el, "with",el, componentTagData.viewModel]; |
There was a problem hiding this comment.
In this case, the component is not being rendered. The case that existed already(this one) is called when an element is inserted into a page using stache (like {{ componentInstance }}), which is why it is queued as Rendering ....
This case the element is being constructed.
Right now this message says
Rendering
<a-tag></a-tag> with<a-tag></a-tag> {foo: Observation}
I think it should say something like
Constructing
<a-tag></a-tag> with viewModel {foo: Observation}
phillipskevin
approved these changes
Sep 17, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #358
The changes:
Run a
can-queuestask a When the component is instantiated withviewModel(lowercase v).