-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
example install run 20220915 - to validate terraform 1.2.8 project-factory removal of impersonate_service_account #47
Comments
see full clean org testing in canada-ca#47
Summary: the unsupported argument error - is an expected result of an API change
|
Validation https://github.com/canada-ca/cloud-guardrails-gcp/blob/main/guardrails-validation/README.md
|
Billing Summary see (needs update for shared billing)
State of billing id associations for type 2 are the following - notice that the terraform service account is in the list as well as the user sa
Reproduced issue where a 3rd party billing id in org 2 is used by org 1 - by adding org 1 sa as BAA in org 2. What happens is the normally inherited roles (beyond BAA) are not properly set in billing when the IAM role is set. As a result Billing Account User must be set manually for the terraform SA in the billing view or we get the following terraform destroy - the deployments, then change the billing id, terraform init and apply
manually set the role on both IAM and billing (why?) If the billing account is from another org - the role will not get inherited automatically from IAM - you must also set it in billing rerun
TL;DR; Shared billing accounts do not get shared IAM roles - they need to be set separately Keep in mind that we need a workaround (see #47) for the fact that if the billing account is of type "shared" where it comes in under "No Organization, ID=0" then any service account created will not get inherited links from IAM set in Billing - these like Billing Account User - need to be set manually. Example
It may take a couple min to show in IAM Checking billing on the shared account expected on billing accounts belonging to this org - via IAM inheritance in billing |
#47 - terraform 1.2.8 breaks without SA removal - critical fix
Notes on rerunning the script after any type of inadvertent typo in variables.tfvar
Example install |
Guardrails install instructions
Determine cloud profile 1=sandbox: https://github.com/canada-ca/cloud-guardrails/blob/master/EN/00_Applicable-Scope.md#applicability-of-guardrails-to-cloud-usage-profiles |
admin at guardrails.gcp.zone clean identity org from scratch - full onboarding prep
note the "trust" checkbox - critical - #41
<img width="1767" alt="Screen Shot 2022-09-15 at 19 08 43" src="https://user-images.githubusercontent.com/24765473/190526445-9e2aa520-a894-4223-a5df-685be
9fa0f25.png">
Notice that there is a pending jira I forgot about with the checkout in cloud shell on my branch
before
as expected - we will add missing roles - these will be automated tomorrow+ in #42
create service account token creator at the org level
add org policy admin
add project creator role
add billing project manager role
full bootstrap
check the 0 items returns and change the output from the iam role additions to not print out
after
diff
variables.tfvar
terraform init - initializes provider plugins - verify this
apply
above worked in last admin-root@cloud-nuage.info in mid June 2022
Since then there may have been terraform changes to module, less likely code changes - verifying both before tomorrows's 2 guardrails installs
triage
https://registry.terraform.io/modules/terraform-google-modules/project-factory/google/latest
after 5 min check
asset inventory
The text was updated successfully, but these errors were encountered: