Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add State Refs #166
base: main
Are you sure you want to change the base?
Add State Refs #166
Changes from all commits
9a2b0f5
6c773f0
699fd71
358b531
d7433f7
eb6e66f
3cc80ee
24d1d4b
6b36651
286888d
988dd29
faa291f
56c88cb
b4dba5f
04dcfc0
0f04d1c
c9d69b4
73beec5
f2b2f13
262f443
f9d7560
26385a6
e891b18
da9ca39
402d35c
793bd88
5eba35e
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This just ignores the adder, doesn't it?
If you want to use the syntax
Widget {.adder.} as ...
. Please report an error if the user tries to useWidget as ... {.adder.}
.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It does not in fact. Like, I didn't think deeper about that fact, but the DSL combination that gets created by
Widget {.somepragma.} as ...
appears to run into the else block in line 105.At least when I added
To the search_entry example it blew up in my face with exactly that error message.