Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: A unary-test expression returns null instead of false #969

Merged
merged 3 commits into from
Jan 21, 2025

Conversation

saig0
Copy link
Member

@saig0 saig0 commented Jan 16, 2025

Description

Fix a regression for unary-test expressions. If the expression evaluates to false and the input value is of a different type, the unary-test should return false instead of null.

Related issues

closes camunda/camunda#27004

saig0 added 3 commits January 16, 2025 15:37
Add test cases for unary-test expressions to verify that an expression returns false.
Fix a regression for unary-test expressions. If the expression evaluates to false and the input value is of a different type, the unary-test should return false instead of null.
Add test cases for the unary-test negation using not().
Copy link
Contributor

@nicpuppa nicpuppa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🥳

@saig0 saig0 added this pull request to the merge queue Jan 21, 2025
Merged via the queue into main with commit 41be554 Jan 21, 2025
5 checks passed
@saig0 saig0 deleted the 27004-unary-test branch January 21, 2025 11:32
@saig0
Copy link
Member Author

saig0 commented Jan 21, 2025

Successfully created backport PR for 1.17:

@saig0
Copy link
Member Author

saig0 commented Jan 21, 2025

Successfully created backport PR for 1.18:

@saig0
Copy link
Member Author

saig0 commented Jan 21, 2025

Successfully created backport PR for 1.19:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEEL/DMN] A unary-test expression returns null instead of false
2 participants