[Backport 1.17] fix: Return null if a date is invalid #900
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a test case to verify that the date() function returns null if the given date is not valid. (cherry picked from commit 2943e92)
Add a test case to verify that a date literal is null if the given date is not valid. (cherry picked from commit f254d79)
Restrict the date/date-time pattern to avoid the creation of invalid dates (e.g. leap year, month with 31 days, etc.). (cherry picked from commit 85806fe)
(cherry picked from commit f828ba5)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Backport of #889 for
1.17.All changes are the same as in the original.
Related issues
closes #867