fix: Unary-test expression with null value #689
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Re-enable ignored tests cases for unary-tests comparison with null.
Fix the parsing of a positive-unary-test expression. Before all expressions were parsed as UnaryTestExpression. As a result, the interpreter evaluated the unary-test (`< 5`) and if it returned false, it compared the input value with the result of the unary-test (i.e. `< 5` => `input < 5 or input = (input < 5)` => `null < 5 or null = (null < 5)` => `null or null = null` => `true`). For positive-unary-test comparison with the input value (e.g. `< 5`), it makes no sense to compare the result of the comparison with the input value again. Fix the behavior in the parser by handing these case separately and give them precedence over the general unary-tests behavior.
Previously, an expression with a range returned false if the input or one of the range values was null. Align the behavior with less/greater than comparison and return null instead.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Align the behavior of unary-tests with a comparison to
null. In both cases, the engine returnsnull.For example, the evaluation of
< 3withnullas the input value returnsnull. Same as the comparisonnull < 3returnsnull.Fixing the behavior in the parser by introducing a special case for simple-positive-unary-test (i.e. comparison with the input value).
Related issues
closes #679