[Backport 1.16] fix(builtin-function): fix string conversion of years-months-durations #644
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Clirr reports a false positive if an inner method is changed. Adjust the configuration of the Clirr plugin to ignore these errors. (cherry picked from commit f9fde28)
* add tests for string conversion of zero-length years-months-duration * add tests for string conversion of negative years-months-duration (cherry picked from commit 38c8e38)
|
@korthout I need you to approve the PR. It's just a backport of a merged PR but the bot did make the job. 😄 |
|
Successfully created backport PR for |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Backport of #636 to
1.16.Related issues
relates to #631