Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Webpack bump #940

Merged
merged 3 commits into from
Oct 9, 2018
Merged

Webpack bump #940

merged 3 commits into from
Oct 9, 2018

Conversation

nikku
Copy link
Member

@nikku nikku commented Oct 9, 2018

This drops numerous unused dependencies from our client build to make it easier to install and run.

Additionally, it attempts to fix appveyor test failures by bumping up the webpack version.

nikku added 2 commits October 9, 2018 11:49
runtime:

* react -> 16.5

test:

* puppeteer
* webpack
* drop post-css loader (unused)
* drop non-chrome karma launchers (unused)
* drop babel-runtime (unused)
@ghost ghost assigned nikku Oct 9, 2018
@ghost ghost added the needs review Review pending label Oct 9, 2018
@ghost ghost assigned philippfromme Oct 9, 2018
@philippfromme
Copy link
Contributor

Test fails due to a known bug in karma-webpack.

Test case fails reproducible on Windows.
Copy link
Contributor

@philippfromme philippfromme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests passing on 🏠.

@nikku
Copy link
Member Author

nikku commented Oct 9, 2018

Waiting for 🗼.

@merge-me merge-me bot merged commit 232f2c6 into next Oct 9, 2018
@delete-merged-branch delete-merged-branch bot deleted the webpack-bump branch October 9, 2018 12:10
@ghost ghost removed the needs review Review pending label Oct 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants