Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

link to incidents on first reference #4350

Merged
merged 4 commits into from
Sep 27, 2024
Merged

link to incidents on first reference #4350

merged 4 commits into from
Sep 27, 2024

Conversation

christinaausley
Copy link
Contributor

Description

Closes https://github.com/camunda/developer-experience/issues/385 -- links to incidents on first reference.

🥳 I think(?) this is our first resolved PushFeedback-related issue??

When should this change go live?

  • This is a bug fix, security concern, or something that needs urgent release support.
  • This is already available but undocumented and should be released within a week.
  • This on a specific schedule and the assignee will coordinate a release with the DevEx team. (apply hold label or convert to draft PR)
  • This is part of a scheduled alpha or minor. (apply alpha or minor label)
  • There is no urgency with this change and can be released at any time.

PR Checklist

  • My changes are for an already released minor and are in /versioned_docs directory.
  • My changes are for the next minor and are in /docs directory (aka /next/).

@christinaausley christinaausley added the component:docs Documentation improvements, including new or updated content label Sep 25, 2024
@christinaausley christinaausley self-assigned this Sep 25, 2024
Copy link
Contributor

👋 🤖 🤔 Hello! Did you make your changes in all the right places?

These files were changed only in docs/. You might want to duplicate these changes in versioned_docs/version-8.5/.

  • docs/components/best-practices/development/understanding-transaction-handling-c7.md
These files were changed only in optimize/. You might want to duplicate these changes in optimize_versioned_docs/version-3.13.0/.
  • optimize/components/userguide/additional-features/ml-dataset.md

You may have done this intentionally, but we wanted to point it out in case you didn't. You can read more about the versioning within our docs in our documentation guidelines.

@christinaausley christinaausley requested a review from a team September 25, 2024 14:25
@mesellings mesellings requested review from mesellings and removed request for a team September 26, 2024 08:27
@mesellings mesellings added deploy Stand up a temporary docs site with this PR and removed deploy Stand up a temporary docs site with this PR labels Sep 26, 2024
mesellings
mesellings previously approved these changes Sep 26, 2024
Copy link
Contributor

@mesellings mesellings left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm, great idea 👍 - just one comment for unrelated instances of i.e. we could tackle whilst we're in the doc?

@github-actions github-actions bot temporarily deployed to camunda-docs September 26, 2024 08:45 Destroyed
Copy link
Contributor

The preview environment relating to the commit 988e220 has successfully been deployed. You can access it at https://preview.docs.camunda.cloud/pr-4350/index.html

Copy link
Contributor

@mesellings mesellings left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm! 👍 🚀

@christinaausley christinaausley merged commit 7cbbe07 into main Sep 27, 2024
8 checks passed
@christinaausley christinaausley deleted the link-incidents branch September 27, 2024 12:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:docs Documentation improvements, including new or updated content
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

2 participants