-
Notifications
You must be signed in to change notification settings - Fork 182
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(kafka): Schema registry documentation #4320
docs(kafka): Schema registry documentation #4320
Conversation
👋 🤖 🤔 Hello! Did you make your changes in all the right places? These files were changed only in docs/. You might want to duplicate these changes in versioned_docs/version-8.5/.
You may have done this intentionally, but we wanted to point it out in case you didn't. You can read more about the versioning within our docs in our documentation guidelines. |
@johnBgood I will review this for you 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@johnBgood I've committed my changes directly to the branch as follows:
- Structural, grammar, readability, standards modifications
I made quite a lot of changes to improve the page that were not connected to this PR, but felt it was worth including them to improve the page and integrate your changes better.
Happy to approve, great job 🚀 👍
@akeller I guess we can merge this, right? It's for 8.6.0. |
@johnBgood I don't see a reason why we can't merge this into the |
Sorry typo...I meant "we can" :) I agree. There's a build error though, not sure why |
Great - I'll check that out and get this merged 👍 |
…ata-serialize-as-json
@johnBgood This can be merged now (just needed to merge main in) 👍 I can also merge if you prefer? |
Feel free to proceed, thank you :) |
🧹 Preview environment for this PR has been torn down. |
Description
Feature Request: support for schema registry in the Kafka connector.
It will be released with 8.6 (not backported).
Related issues:
When should this change go live?
hold
label or convert to draft PR)PR Checklist
/versioned_docs
directory./docs
directory (aka/next/
).