Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(kafka): Schema registry documentation #4320

Conversation

johnBgood
Copy link
Contributor

@johnBgood johnBgood commented Sep 19, 2024

Description

Feature Request: support for schema registry in the Kafka connector.
It will be released with 8.6 (not backported).

Related issues:

When should this change go live?

  • This is a bug fix, security concern, or something that needs urgent release support.
  • This is already available but undocumented and should be released within a week.
  • This on a specific schedule and the assignee will coordinate a release with the DevEx team. (apply hold label or convert to draft PR)
  • This is part of a scheduled alpha or minor. (apply alpha or minor label)
  • There is no urgency with this change and can be released at any time.

PR Checklist

  • My changes are for an already released minor and are in /versioned_docs directory.
  • My changes are for the next minor and are in /docs directory (aka /next/).

@johnBgood johnBgood self-assigned this Sep 19, 2024
Copy link
Contributor

github-actions bot commented Sep 19, 2024

👋 🤖 🤔 Hello! Did you make your changes in all the right places?

These files were changed only in docs/. You might want to duplicate these changes in versioned_docs/version-8.5/.

  • docs/components/connectors/out-of-the-box-connectors/kafka.md
  • docs/self-managed/operational-guides/update-guide/850-to-860.md

You may have done this intentionally, but we wanted to point it out in case you didn't. You can read more about the versioning within our docs in our documentation guidelines.

@johnBgood johnBgood added hold This issue is parked, do not merge. deploy Stand up a temporary docs site with this PR labels Sep 19, 2024
@johnBgood johnBgood added deploy Stand up a temporary docs site with this PR and removed deploy Stand up a temporary docs site with this PR labels Sep 20, 2024
@github-actions github-actions bot temporarily deployed to camunda-docs September 20, 2024 13:25 Destroyed
@johnBgood johnBgood added the target:8.6 Issues included in the 8.6 release label Sep 23, 2024
@github-actions github-actions bot temporarily deployed to camunda-docs September 23, 2024 15:08 Destroyed
@johnBgood johnBgood requested a review from a team September 23, 2024 15:11
@johnBgood johnBgood removed the hold This issue is parked, do not merge. label Sep 23, 2024
@github-actions github-actions bot temporarily deployed to camunda-docs September 23, 2024 15:21 Destroyed
@mesellings mesellings requested review from mesellings and removed request for a team September 23, 2024 15:29
@mesellings
Copy link
Contributor

@johnBgood I will review this for you 👍

@mesellings mesellings self-assigned this Sep 23, 2024
@github-actions github-actions bot temporarily deployed to camunda-docs September 25, 2024 13:34 Destroyed
@github-actions github-actions bot temporarily deployed to camunda-docs September 25, 2024 13:55 Destroyed
@github-actions github-actions bot temporarily deployed to camunda-docs September 25, 2024 14:29 Destroyed
Copy link
Contributor

@mesellings mesellings left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@johnBgood I've committed my changes directly to the branch as follows:

  • Structural, grammar, readability, standards modifications

I made quite a lot of changes to improve the page that were not connected to this PR, but felt it was worth including them to improve the page and integrate your changes better.

Happy to approve, great job 🚀 👍

@github-actions github-actions bot temporarily deployed to camunda-docs September 25, 2024 17:25 Destroyed
@johnBgood
Copy link
Contributor Author

johnBgood commented Sep 27, 2024

@akeller I guess we can merge this, right? It's for 8.6.0.

@mesellings
Copy link
Contributor

@johnBgood I don't see a reason why we can't merge this into the Next docs for the 8.6 release, unless there is something I'm perhaps not aware of?

@johnBgood
Copy link
Contributor Author

johnBgood commented Sep 27, 2024

Sorry typo...I meant "we can" :) I agree.

There's a build error though, not sure why

@mesellings
Copy link
Contributor

Sorry typo...I meant "we can" :) I agree.

There's a build error though, not sure why

Great - I'll check that out and get this merged 👍

@github-actions github-actions bot temporarily deployed to camunda-docs September 27, 2024 12:56 Destroyed
@mesellings
Copy link
Contributor

@johnBgood This can be merged now (just needed to merge main in) 👍 I can also merge if you prefer?

@johnBgood
Copy link
Contributor Author

Feel free to proceed, thank you :)

@mesellings mesellings merged commit ecf8106 into main Sep 27, 2024
7 checks passed
@mesellings mesellings deleted the 874-fr---confluent-kafka-reading-and-write-data-serialize-as-json branch September 27, 2024 13:21
Copy link
Contributor

🧹 Preview environment for this PR has been torn down.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deploy Stand up a temporary docs site with this PR target:8.6 Issues included in the 8.6 release
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

2 participants