Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

backport metrics updates #4280

Merged
merged 3 commits into from
Sep 19, 2024
Merged

backport metrics updates #4280

merged 3 commits into from
Sep 19, 2024

Conversation

conceptualshark
Copy link
Contributor

@conceptualshark conceptualshark commented Sep 10, 2024 •
edited
Loading

Description

Backport the changes from #4262.

When should this change go live?

  • This is a bug fix, security concern, or something that needs urgent release support.
  • This is already available but undocumented and should be released within a week.
  • This on a specific schedule and the assignee will coordinate a release with the DevEx team. (apply hold label or convert to draft PR)
  • This is part of a scheduled alpha or minor. (apply alpha or minor label)
  • There is no urgency with this change and can be released at any time.

PR Checklist

  • My changes are for an already released minor and are in /versioned_docs directory.
  • My changes are for the next minor and are in /docs directory (aka /next/).

@conceptualshark conceptualshark requested a review from a team September 10, 2024 14:22
@conceptualshark conceptualshark marked this pull request as ready for review September 10, 2024 14:23
@conceptualshark conceptualshark self-assigned this Sep 10, 2024
@conceptualshark conceptualshark added component:zeebe Issues related with Zeebe project component:self-managed Docs and issues related to Camunda Platform 8 Self-Managed labels Sep 10, 2024
@mesellings mesellings requested review from mesellings and removed request for a team September 13, 2024 15:14
mesellings
mesellings approved these changes Sep 13, 2024
View reviewed changes
Copy link
Contributor

@mesellings mesellings left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work - much more concise and reads better 🥇 - just the one suggestion about "facilitate", feel free to ignore 👍

versioned_docs/version-8.2/self-managed/zeebe-deployment/operations/metrics.md
To facilitate this, Zeebe exposes an extensive set of metrics.

Zeebe exposes metrics over an embedded HTTP server.
When operating a distributed system like Zeebe, it is important to put proper monitoring in place. To facilitate this, Zeebe exposes an extensive set of metrics over an embedded HTTP server.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
When operating a distributed system like Zeebe, it is important to put proper monitoring in place. To facilitate this, Zeebe exposes an extensive set of metrics over an embedded HTTP server.
When operating a distributed system like Zeebe, it is important to put proper monitoring in place. To help with this, Zeebe exposes an extensive set of metrics over an embedded HTTP server.

Is facilitate too 'wordy'?

versioned_docs/version-8.3/self-managed/zeebe-deployment/operations/metrics.md
To facilitate this, Zeebe exposes an extensive set of metrics.

Zeebe exposes metrics over an embedded HTTP server.
When operating a distributed system like Zeebe, it is important to put proper monitoring in place. To facilitate this, Zeebe exposes an extensive set of metrics over an embedded HTTP server.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See previous comment on 'facilitate', e.g. Hemingway readability/plain English

versioned_docs/version-8.4/self-managed/zeebe-deployment/operations/metrics.md
To facilitate this, Zeebe exposes an extensive set of metrics.

Zeebe exposes metrics over an embedded HTTP server.
When operating a distributed system like Zeebe, it is important to put proper monitoring in place. To facilitate this, Zeebe exposes an extensive set of metrics over an embedded HTTP server.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See previous comments

versioned_docs/version-8.5/self-managed/zeebe-deployment/operations/metrics.md
To facilitate this, Zeebe exposes an extensive set of metrics.

Zeebe exposes metrics over an embedded HTTP server.
When operating a distributed system like Zeebe, it is important to put proper monitoring in place. To facilitate this, Zeebe exposes an extensive set of metrics over an embedded HTTP server.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See previous comments

@conceptualshark conceptualshark merged commit a898ebf into main Sep 19, 2024
11 checks passed
@conceptualshark conceptualshark deleted the cg-backport-metrics branch September 19, 2024 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mesellings mesellings mesellings approved these changes

Assignees

@conceptualshark conceptualshark

Labels
component:self-managed Docs and issues related to Camunda Platform 8 Self-Managed component:zeebe Issues related with Zeebe project
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@conceptualshark @mesellings