Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TW edits: Note and formatting #4251

Conversation

jwulf
Copy link
Member

@jwulf jwulf commented Sep 4, 2024

Description

Here is a suggested edit for the note on start messages and correlationKey values.

Copy link
Contributor

github-actions bot commented Sep 4, 2024

👋 🤖 🤔 Hello! Did you make your changes in all the right places?

These files were changed only in docs/. You might want to duplicate these changes in versioned_docs/version-8.5/.

  • docs/components/modeler/bpmn/message-events/message-events.md

You may have done this intentionally, but we wanted to point it out in case you didn't. You can read more about the versioning within our docs in our documentation guidelines.

Copy link
Contributor

@mesellings mesellings left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work, thanks @jwulf - approved 👍

@akeller akeller added the component:docs Documentation improvements, including new or updated content label Sep 5, 2024
@akeller
Copy link
Member

akeller commented Sep 5, 2024

Should this be backported or is this only relevant for /next/? (Or is there another PR for that?)

@mesellings
Copy link
Contributor

Should this be backported or is this only relevant for /next/? (Or is there another PR for that?)

I think this will need to be backported, but I will do that in the original PR (this one was just an edit from Josh to the note I agreed with the devs)

@mesellings mesellings merged commit e555994 into mes-4466-correlationkey-message-start-event Sep 5, 2024
9 checks passed
@mesellings mesellings deleted the jwulf-msg-start-event-patch branch September 5, 2024 15:50
mesellings added a commit that referenced this pull request Sep 26, 2024
* TW edits: Note and formatting

* suggested edit (#4251)

* Add correlation heading

* Fix admonition

* Backport 8.5 to 1.3

---------

Co-authored-by: Josh Wulf <josh.wulf@camunda.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:docs Documentation improvements, including new or updated content
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

3 participants