Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc(self-managed): drop support of openshift 4.12 and add support of openshift 4.16 #4224

Merged
merged 10 commits into from
Sep 4, 2024

Conversation

leiicamundi
Copy link
Contributor

@leiicamundi leiicamundi commented Aug 30, 2024

Description

OpenShift 4.12 is out of our support matrix since the EOL of the version.
OpenShift 4.16 has been released and tested on our side (camunda/camunda-platform-helm#2131).

When should this change go live?

  • This is a bug fix, security concern, or something that needs urgent release support.
  • This is already available but undocumented and should be released within a week.
  • This on a specific schedule and the assignee will coordinate a release with the DevEx team. (apply hold label or convert to draft PR)
  • This is part of a scheduled alpha or minor. (apply alpha or minor label)
  • There is no urgency with this change and can be released at any time.

PR Checklist

  • My changes are for an already released minor and are in /versioned_docs directory.
  • My changes are for the next minor and are in /docs directory (aka /next/).

@leiicamundi leiicamundi self-assigned this Aug 30, 2024
@leiicamundi leiicamundi added the component:infex Issues related with InfEx project label Aug 30, 2024
@leiicamundi leiicamundi marked this pull request as ready for review September 3, 2024 08:14
@mesellings mesellings self-assigned this Sep 3, 2024
@mesellings mesellings requested review from mesellings and removed request for a team September 3, 2024 09:08
@mesellings
Copy link
Contributor

@leiicamundi I will review this for you 👍

@mesellings mesellings added the deploy Stand up a temporary docs site with this PR label Sep 3, 2024
@github-actions github-actions bot temporarily deployed to camunda-docs September 3, 2024 09:25 Destroyed
@mesellings
Copy link
Contributor

@leiicamundi I notice you talk about dropping 4.13 support, but have only removed the 4.12 table row - just want to confirm this is correct?

@leiicamundi
Copy link
Contributor Author

Hi @mesellings, it's a error on my side, I was referring to 4.12 that is now EOL.

@leiicamundi leiicamundi changed the title doc(self-managed): drop support of openshift 4.13 and add support of openshift 4.16 doc(self-managed): drop support of openshift 4.12 and add support of openshift 4.16 Sep 3, 2024
@github-actions github-actions bot temporarily deployed to camunda-docs September 3, 2024 13:51 Destroyed
@github-actions github-actions bot temporarily deployed to camunda-docs September 3, 2024 14:17 Destroyed
Copy link
Contributor

@mesellings mesellings left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@leiicamundi I've made review edits directly in the branch:

  • Fixed list indentation and numbering
  • Some grammar, text changes

Happy to approve 👍

@github-actions github-actions bot temporarily deployed to camunda-docs September 3, 2024 15:13 Destroyed
@leiicamundi
Copy link
Contributor Author

Thank you, @mesellings! I really appreciate the improvements you made to this doc. 😊

I'll ask either @jessesimpson36 or @Langleu to do a second review from the support perspective.

@theburi, just for your information, we’ve added OpenShift 4.16 to the support matrix and removed version 4.12 (which is now EOL). This is part of our standard maintenance cycle. Could you please approve this change?

Also, @mesellings, I'll have limited access to my computer this week. Please feel free to merge the PR if needed once everyone has validated it.

Thank you!

tls:
enabled: true
secretName: camunda-platform-external-certificate
```
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR seems pretty inconsistent. do you prefer indented codeblocks or non-indented codeblocks?
https://github.com/camunda/camunda-docs/pull/4224/files#diff-a2f46593f55132fad493be0c88dcd7ae6aa247e7afaf0bf345d2102fb9161661R76

Copy link
Contributor

@jessesimpson36 jessesimpson36 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm good with the changes. Personally, I would have preferred if the git-diff wasn't littered with indentation changes but what matters moreso to me is the rendered docs, and those changes are good content.

@mesellings
Copy link
Contributor

I'm good with the changes. Personally, I would have preferred if the git-diff wasn't littered with indentation changes but what matters moreso to me is the rendered docs, and those changes are good content.

Thank you - the indentation is (unfortunately) required by Docusaurus to nest code blocks etc with the relevant list item - I agree it looks messy, but is just how Docusaurus allows you to nest inside lists.

For example, to have the code block align with the prior list item, you need to add 3 spaces as an indent to trigger this, otherwise it is placed 'outside' the list.

@mesellings mesellings merged commit 2665cd7 into main Sep 4, 2024
8 checks passed
@mesellings mesellings deleted the feature/update-openshift-4-16-support branch September 4, 2024 15:00
Copy link
Contributor

github-actions bot commented Sep 4, 2024

🧹 Preview environment for this PR has been torn down.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:infex Issues related with InfEx project deploy Stand up a temporary docs site with this PR
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

4 participants