Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: rename optimize 8 latest tag #4220

Merged
merged 6 commits into from
Sep 17, 2024
Merged

chore: rename optimize 8 latest tag #4220

merged 6 commits into from
Sep 17, 2024

Conversation

OmranAbazid
Copy link
Contributor

@OmranAbazid OmranAbazid commented Aug 30, 2024 •
edited
Loading

related to https://github.com/camunda/camunda-optimize/issues/13498

Description

When should this change go live?

  • This is a bug fix, security concern, or something that needs urgent release support.
  • This is already available but undocumented and should be released within a week.
  • This on a specific schedule and the assignee will coordinate a release with the DevEx team. (apply hold label or convert to draft PR)
  • This is part of a scheduled alpha or minor. (apply alpha or minor label)
  • There is no urgency with this change and can be released at any time.

PR Checklist

  • My changes are for an already released minor and are in /versioned_docs directory.
  • My changes are for the next minor and are in /docs directory (aka /next/).

@OmranAbazid OmranAbazid added hold This issue is parked, do not merge. target:8.6 Issues included in the 8.6 release labels Aug 30, 2024
@OmranAbazid
Copy link
Contributor Author

There are few other latest docker tags that are used in the migration guide.
I will address those in https://github.com/camunda/camunda-optimize/issues/14024

@OmranAbazid OmranAbazid requested a review from a team August 30, 2024 09:41
@akeller
Copy link
Member

akeller commented Aug 30, 2024

Is there a broader impact on the user experience with this change? Should we also include it on the Announcements page? I'm concerned this is a breaking change.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 4, 2024

👋 🤖 🤔 Hello! Did you make your changes in all the right places?

These files were changed only in docs/. You might want to duplicate these changes in versioned_docs/version-8.5/.

  • docs/reference/announcements.md
These files were changed only in optimize/. You might want to duplicate these changes in optimize_versioned_docs/version-3.13.0/.
  • optimize/self-managed/optimize-deployment/migration-update/3.13_8.5-to-3.14_8.6.md
These files were changed only in optimize_versioned_docs/version-3.13.0/. You might want to duplicate these changes in optimize/.
  • optimize_versioned_docs/version-3.13.0/self-managed/optimize-deployment/migration-update/instructions.md

You may have done this intentionally, but we wanted to point it out in case you didn't. You can read more about the versioning within our docs in our documentation guidelines.

@OmranAbazid
Copy link
Contributor Author

Is there a broader impact on the user experience with this change? Should we also include it on the Announcements page? I'm concerned this is a breaking change.

Yea, this make sense. I added a section regarding the docker tag and artifact separation

conceptualshark
conceptualshark reviewed Sep 4, 2024
View reviewed changes
optimize/self-managed/optimize-deployment/migration-update/3.13_8.5-to-3.14_8.6.md Outdated
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR looks good to me, but is there any reason this page isn't yet added to the sidebar?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added it to the sidebar in this PR:
#4241

RomanJRW
RomanJRW previously approved these changes Sep 5, 2024
View reviewed changes
docs/reference/announcements.md Outdated
#### Action required:

- **Camunda 7 Users**: Continue using `3.x` versions and the `latest` Docker tag.
- **Camunda 8 Users**: Update your configurations to use `8.x` versions and the `8-latest` Docker tag.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- **Camunda 8 Users**: Update your configurations to use `8.x` versions and the `8-latest` Docker tag.
- **Camunda 8 Users**: If you haven't already done so, update your configurations to use `8.x` versions and the `8-latest` Docker tag.

@conceptualshark - do you think this makes things clearer? Note that the 8 tags have been available for some time, there has just been no guarantee that C8 customers will have been using them

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 This works for me!

...sioned_docs/version-3.10.0/self-managed/optimize-deployment/migration-update/instructions.md Outdated
Comment on lines 117 to 118
image: registry.camunda.cloud/optimize-ee/optimize:latest # For Camunda 7
# image: registry.camunda.cloud/optimize-ee/optimize:8-latest # For Camunda 8
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe we should default to Camunda 8 here? So C7 would be the one commented out

@RomanJRW RomanJRW added the component:optimize Issues related with Optimize project label Sep 5, 2024
@OmranAbazid OmranAbazid mentioned this pull request Sep 5, 2024
Merged
9 tasks
@OmranAbazid OmranAbazid removed the hold This issue is parked, do not merge. label Sep 17, 2024
@OmranAbazid OmranAbazid enabled auto-merge (squash) September 17, 2024 08:25
@OmranAbazid
Copy link
Contributor Author

@camunda/tech-writers Can you please approve it so that i can merge it.

@OmranAbazid OmranAbazid merged commit 3a18c78 into main Sep 17, 2024
7 checks passed
@OmranAbazid OmranAbazid deleted the 13498-rename-optimize-8-tags branch September 17, 2024 12:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@conceptualshark conceptualshark conceptualshark approved these changes

@RomanJRW RomanJRW RomanJRW left review comments

Assignees

@OmranAbazid OmranAbazid

Labels
component:optimize Issues related with Optimize project target:8.6 Issues included in the 8.6 release
Projects
Developer Experience
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@OmranAbazid @akeller @RomanJRW @conceptualshark