Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: unify API Auth docs (Admin, Camunda 8, and Web Modeler APIs) #4078

Merged
merged 22 commits into from
Aug 26, 2024

Conversation

pepopowitz
Copy link
Collaborator

@pepopowitz pepopowitz commented Jul 26, 2024

Description

Part of #4117.

Unifies the content on our various API Authentication docs, so that each API Auth guide contains the following:

  • Steps to generate a token, in either a SaaS or self-managed (if available) environment
    • In a SaaS environment, clear description of environment variables to be downloaded when creating a client
  • An example auth call, in either a SaaS or self-managed (if available) environment
  • An example usage of a generated token, in either a SaaS or self-managed (if available) environment
  • A description of token expiration
  • (NEW!) Consistent authentication requests between SaaS and self-managed, such that plugging the sample SaaS auth request into an OOTB self-managed environment with the correct variables, will work. (See Incorrect curl command to request bearer token #4092 (comment))

APIs included in this PR

When should this change go live?

  • This is a bug fix, security concern, or something that needs urgent release support.
  • This is already available but undocumented and should be released within a week.
  • This on a specific schedule and the assignee will coordinate a release with the DevEx team. (apply hold label or convert to draft PR)
  • This is part of a scheduled alpha or minor. (apply alpha or minor label)
  • There is no urgency with this change and can be released at any time.

PR Checklist

  • My changes are for an already released minor and are in /versioned_docs directory.
  • My changes are for the next minor and are in /docs directory (aka /next/).

@pepopowitz pepopowitz self-assigned this Jul 26, 2024
@pepopowitz pepopowitz added component:docs Documentation improvements, including new or updated content theme:api-streamline Issues related to the theme of streamlining APIs labels Jul 26, 2024
Copy link
Contributor

github-actions bot commented Jul 26, 2024

👋 🤖 🤔 Hello! Did you make your changes in all the right places?

These files were changed only in docs/. You might want to duplicate these changes in versioned_docs/version-8.5/.

  • docs/apis-tools/camunda-api-rest/camunda-api-rest-authentication.md

You may have done this intentionally, but we wanted to point it out in case you didn't. You can read more about the versioning within our docs in our documentation guidelines.

@pepopowitz pepopowitz requested review from akeller and a team July 26, 2024 20:24
@pepopowitz
Copy link
Collaborator Author

I'm seeking early feedback on these changes. I may decide to introduce per API incrementally instead of all at once. Some open questions I have:

  • Should I do the "deprecated" APIs?
  • Should I do previous versions, or only vNext?

@pepopowitz pepopowitz added the deploy Stand up a temporary docs site with this PR label Jul 26, 2024
@github-actions github-actions bot temporarily deployed to camunda-docs July 26, 2024 20:41 Destroyed
@akeller
Copy link
Member

akeller commented Jul 26, 2024

  • Should I do the "deprecated" APIs?

@pepopowitz see #4071 and the linked Slack convo for updates to the "deprecated APIs"

@pepopowitz
Copy link
Collaborator Author

Note to me (and anyone looking on) that I am ready to acknowledge that the scope of this PR has become too large, and is in danger of living a long time.

Next week I plan to move the tracking of all different auth guides into the linked issue, so that this PR becomes one of many that can be merged incrementally.

@pepopowitz pepopowitz changed the title [WIP] feat: unify API Auth docs [WIP] feat: unify API Auth docs (Admin, Camunda 8, and Web Modeler APIs) Aug 6, 2024
@github-actions github-actions bot temporarily deployed to camunda-docs August 8, 2024 22:41 Destroyed
@pepopowitz pepopowitz marked this pull request as ready for review August 9, 2024 15:42
@pepopowitz
Copy link
Collaborator Author

pepopowitz commented Aug 9, 2024

Hello friends, this PR is ready for review. When the preview site completes deployment, you can find the updated auth guides at:

@github-actions github-actions bot temporarily deployed to camunda-docs August 9, 2024 15:51 Destroyed
@pepopowitz pepopowitz changed the title [WIP] feat: unify API Auth docs (Admin, Camunda 8, and Web Modeler APIs) feat: unify API Auth docs (Admin, Camunda 8, and Web Modeler APIs) Aug 9, 2024
@github-actions github-actions bot temporarily deployed to camunda-docs August 9, 2024 16:41 Destroyed
@github-actions github-actions bot temporarily deployed to camunda-docs August 9, 2024 22:45 Destroyed
@github-actions github-actions bot temporarily deployed to camunda-docs August 12, 2024 17:50 Destroyed
@github-actions github-actions bot temporarily deployed to camunda-docs August 12, 2024 18:06 Destroyed
"clusterSize": 3,
"partitionsCount": 3,
"replicationFactor": 3,
"gatewayVersion": "8.6.0"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Idea - Could be fancy here and get a variable for the product version 🤷‍♀️

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah, in general I didn't feel great about these sample API responses. I want to show enough that it's useful, but not so much that people get lost in the details or it's drifting from the real response.

akeller
akeller previously approved these changes Aug 15, 2024
Copy link
Member

@akeller akeller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Similar to my comments on #4152, I see it as a bonus to sync the tabs down the page and wasn't sure if we need to note anything about the token expiration.

I didn't mention this outside of my comment about the product version, but I did see a couple of places where we reference a "version" that I worry will be out of date, certainly at minors but potentially at other points. I don't think this is a huge risk because these references are in example json.

All of this to say, ✅ 🚀

@akeller akeller requested a review from a team August 15, 2024 16:57
@github-actions github-actions bot temporarily deployed to camunda-docs August 22, 2024 20:58 Destroyed
@github-actions github-actions bot temporarily deployed to camunda-docs August 22, 2024 21:19 Destroyed
@pepopowitz
Copy link
Collaborator Author

This PR is ready for a final review, with all required feedback addressed, and backported to v8.5 (there is no Camunda REST API in version 8.5, so that one was not backported).

@github-actions github-actions bot temporarily deployed to camunda-docs August 23, 2024 18:21 Destroyed
Copy link
Member

@akeller akeller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No blocking feedback, but this did prompt me to realize we don't have anything in the docs about the Zeebe API moving to the Camunda 8 API. That is out of scope of this PR and I will follow up separately.

@pepopowitz pepopowitz merged commit 3dec21c into main Aug 26, 2024
8 checks passed
@pepopowitz pepopowitz deleted the pepopowitz/3649-unify-api-auth-docs branch August 26, 2024 15:46
Copy link
Contributor

🧹 Preview environment for this PR has been torn down.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:docs Documentation improvements, including new or updated content deploy Stand up a temporary docs site with this PR theme:api-streamline Issues related to the theme of streamlining APIs
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants