Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add Unified REST API docs #3919

Merged
merged 9 commits into from
Jun 27, 2024
Merged

Conversation

tmetzke
Copy link
Member

@tmetzke tmetzke commented Jun 11, 2024

Description

  • Adds the Camunda 8 REST API as a new item in the APIs and tools, "deprecated" component APIs are removed
    image
  • Adds the Camunda 8 REST API as a new item in the API sidebar, "replaced" component APIs are moved to deprecated section
    image
  • Adds all v1 endpoints of the Zeebe REST API to the Camunda 8 REST API and adds the job activation endpoint
    image

closes #3918

When should this change go live?

  • This is a bug fix, security concern, or something that needs urgent release support.
  • This is already available but undocumented and should be released within a week.
  • This on a specific schedule and the assignee will coordinate a release with the DevEx team. (apply hold label or convert to draft PR)
  • This is part of a scheduled alpha or minor. (apply alpha or minor label)
  • There is no urgency with this change and can be released at any time.

PR Checklist

  • My changes are for an already released minor and are in /versioned_docs directory.
  • My changes are for the next minor and are in /docs directory (aka /next/).
  • I included my new page in the sidebar file(s).
  • I added a redirect for a renamed or deleted page to the .htaccess file.

@tmetzke tmetzke added kind/feature Issues related with features to be documented component:zeebe Issues related with Zeebe project 8.6.0-alpha3 labels Jun 11, 2024
@tmetzke tmetzke requested a review from a team June 11, 2024 09:55
@tmetzke tmetzke self-assigned this Jun 11, 2024
Copy link
Contributor

github-actions bot commented Jun 11, 2024

👋 🤖 🤔 Hello! Did you make your changes in all the right places?

These files were changed only in docs/. You might want to duplicate these changes in versioned_docs/version-8.5/.

  • docs/apis-tools/camunda-api-rest/camunda-api-rest-authentication.md
  • docs/apis-tools/camunda-api-rest/camunda-api-rest-overview.md
  • docs/apis-tools/camunda-api-rest/sidebar-schema.js
  • docs/apis-tools/camunda-api-rest/specifications/activate-jobs.api.mdx
  • docs/apis-tools/camunda-api-rest/specifications/assign-a-user-task.api.mdx
  • docs/apis-tools/camunda-api-rest/specifications/camunda-8-rest-api.info.mdx
  • docs/apis-tools/camunda-api-rest/specifications/complete-a-user-task.api.mdx
  • docs/apis-tools/camunda-api-rest/specifications/get-cluster-topology.api.mdx
  • docs/apis-tools/camunda-api-rest/specifications/sidebar.js
  • docs/apis-tools/camunda-api-rest/specifications/unassign-a-user-task.api.mdx
  • docs/apis-tools/camunda-api-rest/specifications/update-a-user-task.api.mdx
  • docs/apis-tools/working-with-apis-tools.md

You may have done this intentionally, but we wanted to point it out in case you didn't. You can read more about the versioning within our docs in our documentation guidelines.

@akeller
Copy link
Member

akeller commented Jun 11, 2024

Added @pepopowitz for a DX review since this incorporates updates to the API reference docs via integrated explorer.

@akeller akeller added the dx Documentation infrastructure typically handled by the Camunda DX team label Jun 11, 2024
@akeller
Copy link
Member

akeller commented Jun 11, 2024

@tmetzke 👀 did this go live... today?

@tmetzke tmetzke force-pushed the 3918-job-activation-rest-unified-api branch from fe23a59 to 0c2c4ca Compare June 12, 2024 05:20
@tmetzke
Copy link
Member Author

tmetzke commented Jun 12, 2024

@tmetzke 👀 did this go live... today?

No, this was merged after the 8.6.0-alpha2 code freeze, so it will officially come with alpha3.

Copy link
Member

@akeller akeller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Per an internal conversation, @aleksander-dytko proposes we launch this as "Camunda 8 REST API" instead of "Unified REST API".

@tmetzke can you update this PR? And any supporting assets to reflect this name?

@tmetzke tmetzke force-pushed the 3918-job-activation-rest-unified-api branch from 06633ed to 22a8d9a Compare June 17, 2024 06:12
@tmetzke
Copy link
Member Author

tmetzke commented Jun 17, 2024

Per an internal conversation, @aleksander-dytko proposes we launch this as "Camunda 8 REST API" instead of "Unified REST API".

@tmetzke can you update this PR? And any supporting assets to reflect this name?

Adjusted the PR and the (internal) endpoint definition document.

@tmetzke tmetzke requested a review from akeller June 17, 2024 06:15
@christinaausley christinaausley self-requested a review June 17, 2024 11:24
sidebars.js Outdated Show resolved Hide resolved
@christinaausley
Copy link
Contributor

@tmetzke This looks good text-wise.

  • Once this goes live, I'll add to Postman.
  • Will a tutorial also be incorporated, or are you looking for assistance from the DX team?

sidebars.js Outdated Show resolved Hide resolved
@tmetzke
Copy link
Member Author

tmetzke commented Jun 25, 2024

@tmetzke This looks good text-wise.

  • Once this goes live, I'll add to Postman.
  • Will a tutorial also be incorporated, or are you looking for assistance from the DX team?

I wasn't aware that we have such a thing, I just looked at the existing tutorial now.
With the component APIs becoming unified in the C8 REST API, we should create one unified tutorial, too. It can cover different aspects, e.g. two different sections on specifics to tasks and process instances. However, the general setup and authentication would be equal since it's one API.

akeller
akeller previously approved these changes Jun 25, 2024
@tmetzke tmetzke force-pushed the 3918-job-activation-rest-unified-api branch from 871bea2 to 771cdc1 Compare June 25, 2024 17:49
@tmetzke tmetzke requested a review from akeller June 25, 2024 17:56
Copy link
Member

@akeller akeller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🌟 Bonus points for assisting with the other cleanup 🏆

@tmetzke
Copy link
Member Author

tmetzke commented Jun 26, 2024

@akeller, ready for merge from my end (couldn't remember if I hit squash and merge or if your team does it 😄)

@akeller
Copy link
Member

akeller commented Jun 26, 2024

@tmetzke We are in this weird limbo period ahead of the release. You can merge this but risk releasing it if we need to do any releases before next week. If this is not a risk, you can merge.

@tmetzke
Copy link
Member Author

tmetzke commented Jun 27, 2024

@tmetzke We are in this weird limbo period ahead of the release. You can merge this but risk releasing it if we need to do any releases before next week. If this is not a risk, you can merge.

My most beloved phase of each month. Well, it would be a sneak peak at worst and the artifacts are also already built and released, so 🤷 You cannot access it in SaaS yet but it's also on Next. I'd assume we can live with this.

@akeller
Copy link
Member

akeller commented Jun 27, 2024

YOLO let's go

@akeller akeller merged commit 4c9eed0 into main Jun 27, 2024
8 checks passed
@akeller akeller deleted the 3918-job-activation-rest-unified-api branch June 27, 2024 14:13
@christinaausley
Copy link
Contributor

@tmetzke This looks good text-wise.

  • Once this goes live, I'll add to Postman.
  • Will a tutorial also be incorporated, or are you looking for assistance from the DX team?

I wasn't aware that we have such a thing, I just looked at the existing tutorial now. With the component APIs becoming unified in the C8 REST API, we should create one unified tutorial, too. It can cover different aspects, e.g. two different sections on specifics to tasks and process instances. However, the general setup and authentication would be equal since it's one API.

@tmetzke I'll add an issue to my backlog to create a tutorial for this, and I'll get this added to Postman next Tuesday 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:zeebe Issues related with Zeebe project dx Documentation infrastructure typically handled by the Camunda DX team kind/feature Issues related with features to be documented
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

Add job activation REST endpoint description
4 participants