Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Go Guide #2250

Merged
merged 12 commits into from
Jul 5, 2023
Merged

Update Go Guide #2250

merged 12 commits into from
Jul 5, 2023

Conversation

akeller
Copy link
Member

@akeller akeller commented Jun 15, 2023

Description

Closes #773.

When should this change go live?

  • This change is not yet live and should not be merged until {ADD_DATE} (apply hold label or convert to draft PR)?
  • There is no urgency with this change.
  • This change or page is part of a marketing blog, conference talk, or something else on a schedule.
  • This functionality is already available but undocumented.
  • This is a bug fix or security concern.

PR Checklist

  • I have added changes to the relevant /versioned_docs directory, or they are not for an already released version.
  • I have added changes to the main /docs directory (aka /next/), or they are not for future versions.
  • My changes require an Engineering review, and I've assigned an engineering manager or tech lead as a reviewer, or my changes do not require an Engineering review.
  • My changes require a technical writer review, and I've assigned @christinaausley as a reviewer, or my changes do not require a technical writer review.

@akeller akeller added component:docs Documentation improvements, including new or updated content dx Documentation infrastructure typically handled by the Camunda DX team labels Jun 15, 2023
@akeller akeller self-assigned this Jun 15, 2023
@akeller akeller added the component:zeebe Issues related with Zeebe project label Jun 15, 2023
@akeller
Copy link
Member Author

akeller commented Jun 15, 2023

I need a Go expert to let me know if we should bump up the minimum version in the pre-requisites.

@akeller
Copy link
Member Author

akeller commented Jun 15, 2023

@megglos I added you, but feel free to delegate to a Zeebe/Go expert.

Most of the changes I made were incorporating both Modeler experiences and deploying your model from a file on your desktop programmatically or by clicking the deploy button in Web Modeler.

@akeller akeller requested a review from Sijoma June 27, 2023 16:15
@akeller
Copy link
Member Author

akeller commented Jun 27, 2023

Added @Sijoma for his Go expertise, but he's on leave right now. (Also, stay on leave, this is not urgent!)

@megglos
Copy link
Contributor

megglos commented Jun 28, 2023

Hey @abbasadel given you recently worked on the go client update, could you take a look at this?

@megglos megglos requested a review from abbasadel June 28, 2023 14:30
Copy link
Contributor

@christinaausley christinaausley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is so CLEAN! Approving from a technical perspective.

@akeller akeller marked this pull request as ready for review July 3, 2023 15:41
@akeller
Copy link
Member Author

akeller commented Jul 5, 2023

I added @abbasadel's changes. Can I get a 👍 review so we can merge this?

@christinaausley christinaausley enabled auto-merge (squash) July 5, 2023 20:19
@christinaausley christinaausley merged commit bbb59ad into main Jul 5, 2023
3 checks passed
@christinaausley christinaausley deleted the update-go-guide branch July 5, 2023 20:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:docs Documentation improvements, including new or updated content component:zeebe Issues related with Zeebe project dx Documentation infrastructure typically handled by the Camunda DX team
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Go getting started guide is broken
4 participants