Add support for oAuth mTLS client authorization #161
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
Thanks for the contribution @marinator86. Could you please amend the commit message to type |
Hi @jwulf, done. |
github-actions bot
pushed a commit
that referenced
this pull request
May 15, 2024
## [8.5.4-alpha.1](v8.5.3...v8.5.4-alpha.1) (2024-05-15) ### Features * **oauth:** add conditional loading of client key and cert for getting a token ([#161](#161)) ([f05aa8a](f05aa8a))
github-actions bot
pushed a commit
that referenced
this pull request
May 15, 2024
## [8.5.4-alpha.1](v8.5.3...v8.5.4-alpha.1) (2024-05-15) ### Features * **oauth:** add conditional loading of client key and cert for getting a token ([#161](#161)) ([f05aa8a](f05aa8a))
|
Released in 8.5.4-alpha.1 |
github-actions bot
pushed a commit
that referenced
this pull request
May 24, 2024
## [8.5.4](v8.5.3...v8.5.4) (2024-05-24) ### Bug Fixes * **issue137:** support ZEEBE_REST_ADDRESS and ZEEBE_GRPC_ADDRESS environment variables ([#159](#159)) ([41fdca0](41fdca0)) * **oauth:** correctly expire cached token ([#164](#164)) ([c86e550](c86e550)), closes [#163](#163) ### Features * **camunda8:** support Basic Auth ([d6acdfd](d6acdfd)), closes [#165](#165) * **oauth:** add conditional loading of client key and cert for getting a token ([#161](#161)) ([f05aa8a](f05aa8a)) * **zeebe:** support Zeebe User Task REST API ([022607b](022607b)), closes [#34](#34)
github-actions bot
pushed a commit
that referenced
this pull request
May 24, 2024
## [8.5.4](v8.5.3...v8.5.4) (2024-05-24) ### Bug Fixes * **issue137:** support ZEEBE_REST_ADDRESS and ZEEBE_GRPC_ADDRESS environment variables ([#159](#159)) ([41fdca0](41fdca0)) * **oauth:** correctly expire cached token ([#164](#164)) ([c86e550](c86e550)), closes [#163](#163) ### Features * **camunda8:** support Basic Auth ([d6acdfd](d6acdfd)), closes [#165](#165) * **oauth:** add conditional loading of client key and cert for getting a token ([#161](#161)) ([f05aa8a](f05aa8a)) * **zeebe:** support Zeebe User Task REST API ([022607b](022607b)), closes [#34](#34)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi team,
first of all a big thanks for this sdk! We plan to use it at Mercedes-Benz to connect zeebe workers to our self-managed camunda instance.
In our setup, were we have to put both the oAuth server (keycloak) and the zeebe gateway behind an ingress which requires mTLS client authorization. As I've tested, client authorization has already been supported for grpc connections, but the OAuthProvider did not support it yet when it requests a token.
So I've added code that uses the same config parameters
CAMUNDA_CUSTOM_CERT_CHAIN_PATHandCAMUNDA_CUSTOM_PRIVATE_KEY_PATHto configure got, but only in case they're set. If they're not set,keyandcertparams from got remainundefined, and everything works normal.