-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix default value of includeVariables parameter in tasklist api client #136
Merged
jwulf
merged 1 commit into
camunda:alpha
from
rshamborovskyy:fix/default-value-for-includeVariables
Apr 29, 2024
Merged
Fix default value of includeVariables parameter in tasklist api client #136
jwulf
merged 1 commit into
camunda:alpha
from
rshamborovskyy:fix/default-value-for-includeVariables
Apr 29, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rshamborovskyy
had a problem deploying
to
selfhosted
April 22, 2024 06:23
— with
GitHub Actions
Failure
rshamborovskyy
had a problem deploying
to
selfhosted
April 22, 2024 06:23
— with
GitHub Actions
Failure
rshamborovskyy
had a problem deploying
to
integration
April 22, 2024 06:23
— with
GitHub Actions
Failure
Thanks for this @rshamborovskyy |
rshamborovskyy
had a problem deploying
to
selfhosted
April 22, 2024 06:32
— with
GitHub Actions
Failure
rshamborovskyy
had a problem deploying
to
integration
April 22, 2024 06:32
— with
GitHub Actions
Failure
rshamborovskyy
had a problem deploying
to
selfhosted
April 22, 2024 06:32
— with
GitHub Actions
Failure
rshamborovskyy
had a problem deploying
to
integration
April 22, 2024 08:29
— with
GitHub Actions
Failure
rshamborovskyy
had a problem deploying
to
selfhosted
April 22, 2024 08:29
— with
GitHub Actions
Failure
rshamborovskyy
had a problem deploying
to
selfhosted
April 22, 2024 08:29
— with
GitHub Actions
Failure
github-actions bot
pushed a commit
that referenced
this pull request
Apr 29, 2024
## [8.5.1-alpha.3](v8.5.1-alpha.2...v8.5.1-alpha.3) (2024-04-29) ### Bug Fixes * **tasklist:** correct default value of includeVariables parameter in tasklist variables search ([#136](#136)) ([23af921](23af921))
github-actions bot
pushed a commit
that referenced
this pull request
Apr 29, 2024
## [8.5.1-alpha.3](v8.5.1-alpha.2...v8.5.1-alpha.3) (2024-04-29) ### Bug Fixes * **tasklist:** correct default value of includeVariables parameter in tasklist variables search ([#136](#136)) ([23af921](23af921))
jwulf
added a commit
that referenced
this pull request
May 5, 2024
* feat(repo): add stack traces to async REST errors (#131) * feat(repo): add stack traces to async REST errors * test(operate): disable OAuth in unit test * test(operate): disable OAuth for Operate client in test * test(operate): rename integration test file * chore(repo): run unit test in pre-commit hook * test(operate): change process filename casing * chore(release): 8.5.1-alpha.1 [skip ci] ## [8.5.1-alpha.1](v8.5.0...v8.5.1-alpha.1) (2024-04-09) ### Features * **repo:** add stack traces to async REST errors ([#131](#131)) ([ef8d9c6](ef8d9c6)) * chore(release): 8.5.1-alpha.1 [skip ci] ## [8.5.1-alpha.1](v8.5.0...v8.5.1-alpha.1) (2024-04-09) ### Features * **repo:** add stack traces to async REST errors ([#131](#131)) ([ef8d9c6](ef8d9c6)) * docs(repo): add type of RESTError to JSDoc * docs(repo): update README.md * docs(repo): update README.md Fix Wrong Zeebe client method in readme file * chore(repo): ignore .idea folder in git To prevent IDE-specific settings from interfering with the project setup, the .idea folder, which is created by JetBrains IDEs, is now added to .gitignore. This ensures that developer-specific configurations do not pollute the project repository. * feat(repo): add status code to HTTPError type (#135) * feat(repo): add status code to HTTPError type Errors of type HTTPError now have a status code field * fix(oauth): retry once on 401 to get new token If a REST call fails with 401, we retry once in case it is a token expiry edge-case fixes #125 * test(operate): document the delay and eventual consistency measure in test * fix(oauth): decode jwt to get expiry time fixes #125 * chore(release): 8.5.1-alpha.2 [skip ci] ## [8.5.1-alpha.2](v8.5.1-alpha.1...v8.5.1-alpha.2) (2024-04-20) ### Features * **repo:** add status code to HTTPError type ([#135](#135)) ([cfea141](cfea141)), closes [#125](#125) [#125](#125) * chore(release): 8.5.1-alpha.2 [skip ci] ## [8.5.1-alpha.2](v8.5.1-alpha.1...v8.5.1-alpha.2) (2024-04-20) ### Features * **repo:** add status code to HTTPError type ([#135](#135)) ([cfea141](cfea141)), closes [#125](#125) [#125](#125) * ci(repo): update docker login command * ci(repo): update docker login command * ci: update docker login * build(repo): correct docker username * refactor(oauth): use got in place of node-fetch (#138) * refactor(oauth): use got in place of node-fetch * test(oauth): update cache eviction test * fix(tasklist): correct default value of includeVariables parameter in tasklist variables search (#136) * chore(release): 8.5.1-alpha.3 [skip ci] ## [8.5.1-alpha.3](v8.5.1-alpha.2...v8.5.1-alpha.3) (2024-04-29) ### Bug Fixes * **tasklist:** correct default value of includeVariables parameter in tasklist variables search ([#136](#136)) ([23af921](23af921)) * chore(release): 8.5.1-alpha.3 [skip ci] ## [8.5.1-alpha.3](v8.5.1-alpha.2...v8.5.1-alpha.3) (2024-04-29) ### Bug Fixes * **tasklist:** correct default value of includeVariables parameter in tasklist variables search ([#136](#136)) ([23af921](23af921)) * feat(repo): load system certs when custom cert specified * feat(repo): load system certs when custom cert specified fixes #139 * fix(oauth): throw if cacheDir not writeable on Windows * test(oauth): make cache dir read-only on Windows * test(oauth): make cache dir deleteable on Windows * test(oauth): make token cache dir read-only on Windows * test(oauth): hack around Windows test not throwing * refactor(repo): test self-signed certificate support fixes #139 fixes #141 * test(repo): isolate unit tests and do not run in integration envs * test(repo): run unit tests on Windows runner in CI * feat(zeebe): update gRPC package dep version * ci(repo): run unit tests on Windows for PRs * ci(repo): use cross-env to support Windows runner in CI * test(oauth): use execSync for Windows commands * refactor(repo): use win-ca for Windows system certificates * refactor(repo): refactor code to use win-ca on Windows * refactor(oauth): debug log in CI * revert(oauth): remove certificate debug statement * chore(release): 8.5.1-alpha.4 [skip ci] ## [8.5.1-alpha.4](v8.5.1-alpha.3...v8.5.1-alpha.4) (2024-05-03) ### Features * **repo:** load system certs when custom cert specified ([afce0a7](afce0a7)), closes [#139](#139) [#139](#139) [#141](#141) * chore(release): 8.5.1-alpha.4 [skip ci] ## [8.5.1-alpha.4](v8.5.1-alpha.3...v8.5.1-alpha.4) (2024-05-03) ### Features * **repo:** load system certs when custom cert specified ([afce0a7](afce0a7)), closes [#139](#139) [#139](#139) [#141](#141) --------- Co-authored-by: semantic-release-bot <semantic-release-bot@martynus.net> Co-authored-by: Hasan Alnatour <hassanalnator@gmail.com> Co-authored-by: Roman Shamborovskyy <shamborovskyy@gmail.com>
github-actions bot
pushed a commit
that referenced
this pull request
May 5, 2024
## [8.5.1](v8.5.0...v8.5.1) (2024-05-05) ### Features * **repo:** load system certs when custom cert specified ([#144](#144)) ([8a47d5e](8a47d5e)), closes [#131](#131) [#131](#131) [#131](#131) [#135](#135) [#125](#125) [#125](#125) [#125](#125) [#125](#125) [#125](#125) [#125](#125) [#138](#138) [#136](#136) [#136](#136) [#136](#136) [#139](#139) [#139](#139) [#141](#141) [#139](#139) [#139](#139) [#141](#141) [#139](#139) [#139](#139) [#141](#141)
github-actions bot
pushed a commit
that referenced
this pull request
May 5, 2024
## [8.5.1](v8.5.0...v8.5.1) (2024-05-05) ### Features * **repo:** load system certs when custom cert specified ([#144](#144)) ([8a47d5e](8a47d5e)), closes [#131](#131) [#131](#131) [#131](#131) [#135](#135) [#125](#125) [#125](#125) [#125](#125) [#125](#125) [#125](#125) [#125](#125) [#138](#138) [#136](#136) [#136](#136) [#136](#136) [#139](#139) [#139](#139) [#141](#141) [#139](#139) [#139](#139) [#141](#141) [#139](#139) [#139](#139) [#141](#141)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
I am getting 500 error without specifying optional
includeVariables
, so I have to workaround it like so:But anyway, here's the fix for that problem.