-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update README.md #133
Update README.md #133
Conversation
Fix Wrong Zeebe client method in readme file
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this @hassan-alnator. Good catch!
It needs to be a pull request against the alpha
branch. I've updated that.
Also, it needs the commit message amended to pass commitlint. Please see the details in step 7 here: https://github.com/camunda/camunda-8-js-sdk/blob/alpha/CONTRIBUTING.md
Are you able to amend the commit message? It should be something like: docs(repo): update README.md
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you please amend the commit message to docs(repo): update README.md
docs(repo): update README.md
@jwulf Done |
Oops, you've committed the I appreciate you working on this with me. This is the first external contribution to the SDK, so it's greasing the groove for everyone who comes after. |
To prevent IDE-specific settings from interfering with the project setup, the .idea folder, which is created by JetBrains IDEs, is now added to .gitignore. This ensures that developer-specific configurations do not pollute the project repository.
Change Completed , More than happy to support a project I love 😄 |
@hassan-alnator - could you please sign the Contributor License Agreement here: https://cla-assistant.io/camunda/camunda-8-js-sdk |
Fix Wrong Zeebe client method in readme file