Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README.md #133

Merged
merged 5 commits into from
Apr 19, 2024
Merged

Update README.md #133

merged 5 commits into from
Apr 19, 2024

Conversation

hassan-alnator
Copy link
Contributor

Fix Wrong Zeebe client method in readme file

Fix Wrong Zeebe client method in readme file
@CLAassistant
Copy link

CLAassistant commented Apr 14, 2024

CLA assistant check
All committers have signed the CLA.

@jwulf jwulf changed the base branch from main to alpha April 16, 2024 10:06
Copy link
Member

@jwulf jwulf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this @hassan-alnator. Good catch!

It needs to be a pull request against the alpha branch. I've updated that.

Also, it needs the commit message amended to pass commitlint. Please see the details in step 7 here: https://github.com/camunda/camunda-8-js-sdk/blob/alpha/CONTRIBUTING.md

Are you able to amend the commit message? It should be something like: docs(repo): update README.md

Copy link
Member

@jwulf jwulf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please amend the commit message to docs(repo): update README.md

@hassan-alnator
Copy link
Contributor Author

@jwulf Done

@jwulf
Copy link
Member

jwulf commented Apr 18, 2024

Oops, you've committed the .idea directory. If you could add .idea to the repo's .gitignore and do git rm --cached .idea and commit, you'll take those file out of the commit and the repo will be set up for you and anyone else using a JetBrains IDE, and that would be awesome.

I appreciate you working on this with me. This is the first external contribution to the SDK, so it's greasing the groove for everyone who comes after.

To prevent IDE-specific settings from interfering with the project setup,
the .idea folder, which is created by JetBrains IDEs, is now added to
.gitignore. This ensures that developer-specific configurations do not
pollute the project repository.
@hassan-alnator
Copy link
Contributor Author

hassan-alnator commented Apr 18, 2024

Oops, you've committed the .idea directory. If you could add .idea to the repo's .gitignore and do git rm --cached .idea and commit, you'll take those file out of the commit and the repo will be set up for you and anyone else using a JetBrains IDE, and that would be awesome.

I appreciate you working on this with me. This is the first external contribution to the SDK, so it's greasing the groove for everyone who comes after.

Change Completed , More than happy to support a project I love 😄

@jwulf jwulf merged commit 9be237d into camunda:alpha Apr 19, 2024
1 check was pending
@jwulf
Copy link
Member

jwulf commented May 5, 2024

@hassan-alnator - could you please sign the Contributor License Agreement here: https://cla-assistant.io/camunda/camunda-8-js-sdk

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants