Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error: Cannot find module 'lib' in require stack... #114

Closed
MarcBouteiller opened this issue Apr 5, 2024 · 5 comments
Closed

Error: Cannot find module 'lib' in require stack... #114

MarcBouteiller opened this issue Apr 5, 2024 · 5 comments
Assignees
Milestone

Comments

@MarcBouteiller
Copy link

MarcBouteiller commented Apr 5, 2024

Hi ! I know this version is in alpha, but I wanted to submit my issue in case of.
An error is thrown when starting a NestJS project with camunda8/sdk@8.5.0-alpha.3 or camunda8/sdk@8.5.0-alpha.4

Error: Cannot find module 'lib'
Require stack:
- /home/xxx/workspace/projects/edl/poc/camunda/node_modules/.pnpm/@camunda8+sdk@8.5.0-alpha.4/node_modules/@camunda8/sdk/dist/admin/lib/AdminApiClient.js
- /home/xxx/workspace/projects/edl/poc/camunda/node_modules/.pnpm/@camunda8+sdk@8.5.0-alpha.4/node_modules/@camunda8/sdk/dist/admin/index.js
- /home/xxx/workspace/projects/edl/poc/camunda/node_modules/.pnpm/@camunda8+sdk@8.5.0-alpha.4/node_modules/@camunda8/sdk/dist/index.js
- /home/xxx/workspace/projects/edl/poc/camunda/dist/process.service.js
- /home/xxx/workspace/projects/edl/poc/camunda/dist/app.controller.js
- /home/xxx/workspace/projects/edl/poc/camunda/dist/app.module.js
- /home/xxx/workspace/projects/edl/poc/camunda/dist/main.js

SDK Component

All

Expected Behavior

The 'lib' is found

Current Behavior

The 'lib' is not found

Possible Solution

the path of 'lib' (or any other require() in the compiled js) seems to target a file in a same folder.

Steps to Reproduce

  1. nest new my-project
  2. Call the camunda8 constructor anywhere (ex: const camunda = new Camunda8() in the controller)
  3. npm run start:dev

Context (Environment)

NodeJS 20
NestJS@10 project
PNPM

@jwulf
Copy link
Member

jwulf commented Apr 6, 2024

Thanks for reporting this. I know that alpha.3 had this issue. Let me reproduce it with alpha.4

@jwulf jwulf self-assigned this Apr 6, 2024
@jwulf jwulf added this to the 8.5.0 milestone Apr 6, 2024
jwulf added a commit that referenced this issue Apr 7, 2024
@jwulf jwulf mentioned this issue Apr 7, 2024
jwulf added a commit that referenced this issue Apr 7, 2024
* fix(repo): use relative paths in source

fixes #114

* test(repo): fix relative path in jest setup

* test(repo): fix relative path to zeebe

* test(repo): convert tests to relative paths

* revert(github): remove spurious commitlint config file
@jwulf
Copy link
Member

jwulf commented Apr 7, 2024

This is due to the way that the package is structured in TypeScript, see here: #110

Two things: first of all, to solve this, I am taking out the module mapping and using explicit relative paths in the source, to avoid complicated transpilation configuration.

Secondly: all the tests in CI are running using ts-jest, which means they prove the code before it is transpiled. To address this, and make sure that transpilation and packaging issues which are not caught by the current test suite don't get through, I am adding to the CI testing an npm build step followed by a test run using the transpiled code in dist and the package.json entry point. This simulates as close as possible the code that will be installed by npm i when the package is installed, and will catch issues of this class this before they hit NPM.

This will be done in the next 24 hours.

@jwulf
Copy link
Member

jwulf commented Apr 7, 2024

I've released alpha.5 which addresses this.

Now, I will write the tests to make sure that we catch issues of this class before a package gets released.

@jwulf
Copy link
Member

jwulf commented Apr 8, 2024

alpha.6 includes the smoke test step, and also fixes an issue where instantiating a Camunda8 object with OAuth disabled would throw an error.

@jwulf jwulf closed this as completed Apr 8, 2024
jwulf added a commit that referenced this issue Apr 8, 2024
* ci(repo): create npm publish workflow (#100)

* Remove-docs (#101)

* docs(repo): remove docs

* docs(repo): add docs folder to .gitignore

* ci(repo): update publish workflow (#102)

* ci(repo): configure renovate to run against alpha branch (#103)

* ci(repo): configure renovate to run against alpha branch

* ci(repo): add workflow step to merge to alpha from main on release

* chore(release): 8.5.0-alpha.1 [skip ci]

# [8.5.0-alpha.1](v8.4.0...v8.5.0-alpha.1) (2024-04-04)

### Features

* **oauth:** support optional scope in OAuth request ([#25](#25)) ([0451b80](0451b80))
* **operate:** add multitenant support and lossless Json parsing ([#82](#82)) ([cf49a71](cf49a71)), closes [#78](#78) [#67](#67)
* **repo:** add enhanced debug output for http errors ([#88](#88)) ([881b039](881b039)), closes [#87](#87)
* **tasklist:** add multitenant support to tasklist ([#85](#85)) ([46bb564](46bb564))
* **zeebe:** add MigrateProcessInstance ([#97](#97)) ([2a9a123](2a9a123)), closes [#49](#49)
* **zeebe:** implement deleteResource ([#73](#73)) ([0cd08b7](0cd08b7))
* **zeebe:** implement lossless parsing of job payload ([#95](#95)) ([57f3ea8](57f3ea8)), closes [#81](#81)
* **zeebe:** normalise useragent, thread config ([#94](#94)) ([c1c4211](c1c4211))
* **zeebe:** remove deployProcess method ([#71](#71)) ([6cb98f0](6cb98f0))

* test(repo): skip jest global setup for unit tests (#106)


Fixes #105

* build(repo): parallelise publish workflow

* build(repo): fix parallelisation

* fix(repo): add note on "supported" (#107)

Fixes #70

* chore(release): 8.5.0-alpha.2 [skip ci]

# [8.5.0-alpha.2](v8.5.0-alpha.1...v8.5.0-alpha.2) (2024-04-05)

### Bug Fixes

* **repo:** add note on "supported" ([#107](#107)) ([fc45d61](fc45d61)), closes [#70](#70)

* fix(repo): only git commit on npm publish success

* chore(release): 8.5.0-alpha.3 [skip ci]

# [8.5.0-alpha.3](v8.5.0-alpha.2...v8.5.0-alpha.3) (2024-04-05)

### Bug Fixes

* **repo:** only git commit on npm publish success ([9012764](9012764))

* chore(release): 8.5.0-alpha.3 [skip ci]

# [8.5.0-alpha.3](v8.5.0-alpha.2...v8.5.0-alpha.3) (2024-04-05)

### Bug Fixes

* **repo:** only git commit on npm publish success ([9012764](9012764))

* build(repo): configure semantic release (#109)

fixes #108

* fix(repo): use ts-patch to transform module mapping in output (#112)

* fix(repo): use ts-patch to transform module mapping in output

fixes #110

* build(repo): add missing tsconfig-paths

* chore(release): 8.5.0-alpha.4 [skip ci]

# [8.5.0-alpha.4](v8.5.0-alpha.3...v8.5.0-alpha.4) (2024-04-05)

### Bug Fixes

* **repo:** use ts-patch to transform module mapping in output ([#112](#112)) ([7efdcf3](7efdcf3)), closes [#110](#110)

* chore(release): 8.5.0-alpha.4 [skip ci]

# [8.5.0-alpha.4](v8.5.0-alpha.3...v8.5.0-alpha.4) (2024-04-05)

### Bug Fixes

* **repo:** use ts-patch to transform module mapping in output ([#112](#112)) ([7efdcf3](7efdcf3)), closes [#110](#110)

* ci(repo): parallelise tests and use npm install in CI (#116)

fixes #115

* Jwulf/issue114 (#117)

* fix(repo): use relative paths in source

fixes #114

* test(repo): fix relative path in jest setup

* test(repo): fix relative path to zeebe

* test(repo): convert tests to relative paths

* revert(github): remove spurious commitlint config file

* fix(repo): make fix type commits release a new package

* ci(repo): wrap long lines in commit messages

* ci(repo): wrap footer lines at 100 characters in semantic-release config

* ci(repo): break commit msgs to 100 chars via husky hook

* ci(repo): disable husky during semantic-release

* chore(release): 8.5.0-alpha.5 [skip ci]

# [8.5.0-alpha.5](v8.5.0-alpha.4...v8.5.0-alpha.5) (2024-04-07)

### Bug Fixes

* **repo:** make fix type commits release a new package ([ded83cf](ded83cf))

* chore(release): 8.5.0-alpha.5 [skip ci]

# [8.5.0-alpha.5](v8.5.0-alpha.4...v8.5.0-alpha.5) (2024-04-07)

### Bug Fixes

* **repo:** make fix type commits release a new package ([ded83cf](ded83cf))

* Issue118 (#119)

* test(repo): add smoke test and type surface tests
fixes #118
* ci(repo): run smoke test in CI
* fix(camunda8): respect OAuth disabled flag

* fix(issue118): add smoke test and type surface tests

* test(repo): add smoke test and type surface tests
fixes #118
* ci(repo): run smoke test in CI
* fix(camunda8): respect OAuth disabled flag

* release(repo): trigger a new release

* chore(release): 8.5.0-alpha.6 [skip ci]

# [8.5.0-alpha.6](v8.5.0-alpha.5...v8.5.0-alpha.6) (2024-04-08)

### Bug Fixes

* **issue118:** add smoke test and type surface tests ([fe0c709](fe0c709)), closes [#118](#118)

* chore(release): 8.5.0-alpha.6 [skip ci]

# [8.5.0-alpha.6](v8.5.0-alpha.5...v8.5.0-alpha.6) (2024-04-08)

### Bug Fixes

* **issue118:** add smoke test and type surface tests ([fe0c709](fe0c709)), closes [#118](#118)

* ci(repo): add CodeQL scanning (#120)

fixes #51

---------

Co-authored-by: semantic-release-bot <semantic-release-bot@martynus.net>
jwulf added a commit that referenced this issue Apr 8, 2024
* Release 8.5.0 (#124)

* ci(repo): create npm publish workflow (#100)

* Remove-docs (#101)

* docs(repo): remove docs

* docs(repo): add docs folder to .gitignore

* ci(repo): update publish workflow (#102)

* ci(repo): configure renovate to run against alpha branch (#103)

* ci(repo): configure renovate to run against alpha branch

* ci(repo): add workflow step to merge to alpha from main on release

* chore(release): 8.5.0-alpha.1 [skip ci]

# [8.5.0-alpha.1](v8.4.0...v8.5.0-alpha.1) (2024-04-04)

### Features

* **oauth:** support optional scope in OAuth request ([#25](#25)) ([0451b80](0451b80))
* **operate:** add multitenant support and lossless Json parsing ([#82](#82)) ([cf49a71](cf49a71)), closes [#78](#78) [#67](#67)
* **repo:** add enhanced debug output for http errors ([#88](#88)) ([881b039](881b039)), closes [#87](#87)
* **tasklist:** add multitenant support to tasklist ([#85](#85)) ([46bb564](46bb564))
* **zeebe:** add MigrateProcessInstance ([#97](#97)) ([2a9a123](2a9a123)), closes [#49](#49)
* **zeebe:** implement deleteResource ([#73](#73)) ([0cd08b7](0cd08b7))
* **zeebe:** implement lossless parsing of job payload ([#95](#95)) ([57f3ea8](57f3ea8)), closes [#81](#81)
* **zeebe:** normalise useragent, thread config ([#94](#94)) ([c1c4211](c1c4211))
* **zeebe:** remove deployProcess method ([#71](#71)) ([6cb98f0](6cb98f0))

* test(repo): skip jest global setup for unit tests (#106)


Fixes #105

* build(repo): parallelise publish workflow

* build(repo): fix parallelisation

* fix(repo): add note on "supported" (#107)

Fixes #70

* chore(release): 8.5.0-alpha.2 [skip ci]

# [8.5.0-alpha.2](v8.5.0-alpha.1...v8.5.0-alpha.2) (2024-04-05)

### Bug Fixes

* **repo:** add note on "supported" ([#107](#107)) ([fc45d61](fc45d61)), closes [#70](#70)

* fix(repo): only git commit on npm publish success

* chore(release): 8.5.0-alpha.3 [skip ci]

# [8.5.0-alpha.3](v8.5.0-alpha.2...v8.5.0-alpha.3) (2024-04-05)

### Bug Fixes

* **repo:** only git commit on npm publish success ([9012764](9012764))

* chore(release): 8.5.0-alpha.3 [skip ci]

# [8.5.0-alpha.3](v8.5.0-alpha.2...v8.5.0-alpha.3) (2024-04-05)

### Bug Fixes

* **repo:** only git commit on npm publish success ([9012764](9012764))

* build(repo): configure semantic release (#109)

fixes #108

* fix(repo): use ts-patch to transform module mapping in output (#112)

* fix(repo): use ts-patch to transform module mapping in output

fixes #110

* build(repo): add missing tsconfig-paths

* chore(release): 8.5.0-alpha.4 [skip ci]

# [8.5.0-alpha.4](v8.5.0-alpha.3...v8.5.0-alpha.4) (2024-04-05)

### Bug Fixes

* **repo:** use ts-patch to transform module mapping in output ([#112](#112)) ([7efdcf3](7efdcf3)), closes [#110](#110)

* chore(release): 8.5.0-alpha.4 [skip ci]

# [8.5.0-alpha.4](v8.5.0-alpha.3...v8.5.0-alpha.4) (2024-04-05)

### Bug Fixes

* **repo:** use ts-patch to transform module mapping in output ([#112](#112)) ([7efdcf3](7efdcf3)), closes [#110](#110)

* ci(repo): parallelise tests and use npm install in CI (#116)

fixes #115

* Jwulf/issue114 (#117)

* fix(repo): use relative paths in source

fixes #114

* test(repo): fix relative path in jest setup

* test(repo): fix relative path to zeebe

* test(repo): convert tests to relative paths

* revert(github): remove spurious commitlint config file

* fix(repo): make fix type commits release a new package

* ci(repo): wrap long lines in commit messages

* ci(repo): wrap footer lines at 100 characters in semantic-release config

* ci(repo): break commit msgs to 100 chars via husky hook

* ci(repo): disable husky during semantic-release

* chore(release): 8.5.0-alpha.5 [skip ci]

# [8.5.0-alpha.5](v8.5.0-alpha.4...v8.5.0-alpha.5) (2024-04-07)

### Bug Fixes

* **repo:** make fix type commits release a new package ([ded83cf](ded83cf))

* chore(release): 8.5.0-alpha.5 [skip ci]

# [8.5.0-alpha.5](v8.5.0-alpha.4...v8.5.0-alpha.5) (2024-04-07)

### Bug Fixes

* **repo:** make fix type commits release a new package ([ded83cf](ded83cf))

* Issue118 (#119)

* test(repo): add smoke test and type surface tests
fixes #118
* ci(repo): run smoke test in CI
* fix(camunda8): respect OAuth disabled flag

* fix(issue118): add smoke test and type surface tests

* test(repo): add smoke test and type surface tests
fixes #118
* ci(repo): run smoke test in CI
* fix(camunda8): respect OAuth disabled flag

* release(repo): trigger a new release

* chore(release): 8.5.0-alpha.6 [skip ci]

# [8.5.0-alpha.6](v8.5.0-alpha.5...v8.5.0-alpha.6) (2024-04-08)

### Bug Fixes

* **issue118:** add smoke test and type surface tests ([fe0c709](fe0c709)), closes [#118](#118)

* chore(release): 8.5.0-alpha.6 [skip ci]

# [8.5.0-alpha.6](v8.5.0-alpha.5...v8.5.0-alpha.6) (2024-04-08)

### Bug Fixes

* **issue118:** add smoke test and type surface tests ([fe0c709](fe0c709)), closes [#118](#118)

* ci(repo): add CodeQL scanning (#120)

fixes #51

---------

Co-authored-by: semantic-release-bot <semantic-release-bot@martynus.net>

* release: trigger a new release

* chore(release): 8.4.1 [skip ci]

## [8.4.1](v8.4.0...v8.4.1) (2024-04-08)

### Features

* **oauth:** support optional scope in OAuth request ([#25](#25)) ([0451b80](0451b80))
* **operate:** add multitenant support and lossless Json parsing ([#82](#82)) ([cf49a71](cf49a71)), closes [#78](#78) [#67](#67)
* **repo:** add enhanced debug output for http errors ([#88](#88)) ([881b039](881b039)), closes [#87](#87)
* **tasklist:** add multitenant support to tasklist ([#85](#85)) ([46bb564](46bb564))
* **zeebe:** add MigrateProcessInstance ([#97](#97)) ([2a9a123](2a9a123)), closes [#49](#49)
* **zeebe:** implement deleteResource ([#73](#73)) ([0cd08b7](0cd08b7))
* **zeebe:** implement lossless parsing of job payload ([#95](#95)) ([57f3ea8](57f3ea8)), closes [#81](#81)
* **zeebe:** normalise useragent, thread config ([#94](#94)) ([c1c4211](c1c4211))
* **zeebe:** remove deployProcess method ([#71](#71)) ([6cb98f0](6cb98f0))

* chore(release): 8.4.1 [skip ci]

## [8.4.1](v8.4.0...v8.4.1) (2024-04-08)

### Features

* **oauth:** support optional scope in OAuth request ([#25](#25)) ([0451b80](0451b80))
* **operate:** add multitenant support and lossless Json parsing ([#82](#82)) ([cf49a71](cf49a71)), closes [#78](#78) [#67](#67)
* **repo:** add enhanced debug output for http errors ([#88](#88)) ([881b039](881b039)), closes [#87](#87)
* **tasklist:** add multitenant support to tasklist ([#85](#85)) ([46bb564](46bb564))
* **zeebe:** add MigrateProcessInstance ([#97](#97)) ([2a9a123](2a9a123)), closes [#49](#49)
* **zeebe:** implement deleteResource ([#73](#73)) ([0cd08b7](0cd08b7))
* **zeebe:** implement lossless parsing of job payload ([#95](#95)) ([57f3ea8](57f3ea8)), closes [#81](#81)
* **zeebe:** normalise useragent, thread config ([#94](#94)) ([c1c4211](c1c4211))
* **zeebe:** remove deployProcess method ([#71](#71)) ([6cb98f0](6cb98f0))

---------

Co-authored-by: semantic-release-bot <semantic-release-bot@martynus.net>
@MarcBouteiller
Copy link
Author

Thanks for you work !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: ✅ Done
Development

No branches or pull requests

2 participants