bug(object-mapper): Fix our custom mappers creation to avoid mutating the initial ObjectMapper #804
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… the initial ObjectMapper
chillleader
approved these changes
May 31, 2024
johnBgood
added a commit
that referenced
this pull request
May 31, 2024
…2648 bug(object-mapper): Fix our custom mappers creation to avoid mutating the initial ObjectMapper
johnBgood
added a commit
that referenced
this pull request
May 31, 2024
…2648 bug(object-mapper): Fix our custom mappers creation to avoid mutating the initial ObjectMapper
johnBgood
added a commit
that referenced
this pull request
May 31, 2024
…2648 (#806) bug(object-mapper): Fix our custom mappers creation to avoid mutating the initial ObjectMapper
johnBgood
added a commit
that referenced
this pull request
May 31, 2024
…2648 (#805) bug(object-mapper): Fix our custom mappers creation to avoid mutating the initial ObjectMapper
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We can't set a process variable to null, because the ObjectMapper was configured to ignore NULL values.
This was a side effect due to the
ZeebeObjectMapperandSdkObjectMapperusing theobjectMapperand mutating it.To avoid breaking things, I just copied the initial mapper to keep the current behavior for the said mappers while avoiding the mutations.
I plan to backport this in:
closes camunda/connectors#2648