Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

beackport 8.5: Feature/reorganize properties (#662) #690

Merged
merged 1 commit into from
Mar 22, 2024

Conversation

jonathanlukas
Copy link
Collaborator

  • deprecate old properties

  • refactoring usage of properties

  • wip

  • wip

  • wip

  • wip

  • legacy config still working

  • removed unused configuration

  • added backend issuer url to default saas props

  • adjusted readme

  • fixed broken test

  • functionality of new property strategy proved

  • moved from spring profiles to properties post processor

  • moved tests as well

  • worker overrides are applied over global overrides

  • typo

  • table format

  • add a general comment for first orientation

  • removed property

  • typo

  • updated docs about variable fetching

  • typo

  • update link to reflect new properties class

  • typo

  • deprecated classes

  • updated executorserviceconfig to reflect new properties

  • added a test to assert all deprecations are applied correctly

  • applied deprecation notices to all legacy properties

  • adjusted a reason comment

(cherry picked from commit ef37537)

* deprecate old properties

* refactoring usage of properties

* wip

* wip

* wip

* wip

* legacy config still working

* removed unused configuration

* added backend issuer url to default saas props

* adjusted readme

* fixed broken test

* functionality of new property strategy proved

* moved from spring profiles to properties post processor

* moved tests as well

* worker overrides are applied over global overrides

* typo

* table format

* add a general comment for first orientation

* removed property

* typo

* updated docs about variable fetching

* typo

* update link to reflect new properties class

* typo

* deprecated classes

* updated executorserviceconfig to reflect new properties

* added a test to assert all deprecations are applied correctly

* applied deprecation notices to all legacy properties

* adjusted a reason comment

(cherry picked from commit ef37537)
@jonathanlukas jonathanlukas changed the title Feature/reorganize properties (#662) beackport 8.5: Feature/reorganize properties (#662) Mar 19, 2024
@chillleader
Copy link
Collaborator

@jonathanlukas Should we perhaps include it in 8.6 as the first supported version? I'd rather not change the configuration on the connectors side at the moment and adopt this in the 8.6-alpha1.

@jonathanlukas
Copy link
Collaborator Author

I can relate to this. But, the new properties structure should still work for old properties.

Is there any way to find this new properties structure in the camunda sdk?

Copy link
Collaborator

@chillleader chillleader left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're right, seems backward compatible. Then I'm fine with backporting it 👍

Regarding having this in the upcoming Camunda SDK, I'm not sure how this fits in, since I don't know what kind of structure is planned for that project

@chillleader chillleader merged commit cabf75b into release/8.5 Mar 22, 2024
4 checks passed
@jonathanlukas jonathanlukas deleted the backport/8.5/reorganize-properties branch April 2, 2024 10:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants