Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

backport/8.4: fix(common-authentication): Token not refreshed #632

Merged
merged 7 commits into from
Feb 15, 2024

Conversation

jonathanlukas
Copy link
Collaborator

@jonathanlukas jonathanlukas commented Feb 8, 2024

Currently, the token provider not refresh a token unless it is reported invalid by the server.

This behaviour does not work with the zeebe client.

This fix refactors the jwt authentication to check the validity of a token BEFORE sending the request and eventually refreshing the token upfront.

closes #631

@CLAassistant
Copy link

CLAassistant commented Feb 8, 2024

CLA assistant check
All committers have signed the CLA.

@jonathanlukas jonathanlukas changed the base branch from main to release/8.4 February 8, 2024 14:48
@jonathanlukas jonathanlukas self-assigned this Feb 8, 2024
@jonathanlukas jonathanlukas changed the title fix(common-authentication): Token not refreshed backport/8.4: fix(common-authentication): Token not refreshed Feb 9, 2024
@jonathanlukas jonathanlukas force-pushed the 631-zeebe-token-not-being-refreshed branch from 51c21bf to 55303c3 Compare February 15, 2024 11:37
@jonathanlukas jonathanlukas merged commit 5d33f0c into release/8.4 Feb 15, 2024
4 checks passed
@jonathanlukas jonathanlukas deleted the 631-zeebe-token-not-being-refreshed branch February 15, 2024 11:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants