Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update gnui to last version #2

Merged
merged 2 commits into from
Jan 17, 2024
Merged

chore: update gnui to last version #2

merged 2 commits into from
Jan 17, 2024

Conversation

fgravin
Copy link
Member

@fgravin fgravin commented Jan 12, 2024

update code accordingly.
still an issue with gn4Provider import

The goal is to have a gnui npm package that works correctly.
Depends on geonetwork/geonetwork-ui#762 to make it work

update code accordingly.
still an issue with gn4Provider import
@fgravin fgravin requested a review from tkohr January 12, 2024 08:18
@tkohr
Copy link
Member

tkohr commented Jan 12, 2024

Can't get it to work adding the gn-ui package via yalc, will wait for upstream to be merged.

@tkohr
Copy link
Member

tkohr commented Jan 15, 2024

Hum, I'm still getting > NX Missing "./libs/api/repository/src/lib/gn4" specifier in "geonetwork-ui" package on npm start after bumping to geonetwork-ui to ^2.2.0-dev.c15a456 (which should include necessary merge). Tried nx reset... Am I missing anything else?

Copy link
Member

@tkohr tkohr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the update @fgravin ! App starts fine now after npm i -f 🙂

Sidenote: package-lock.json seems to be out of sync with package.json as npm ci -f does not pass.

@fgravin fgravin merged commit 1d86867 into main Jan 17, 2024
1 of 5 checks passed
@fgravin fgravin deleted the update-gnui branch January 17, 2024 07:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants