Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix interface override defaults #5357

Merged
merged 2 commits into from
Nov 1, 2019
Merged

Fix interface override defaults #5357

merged 2 commits into from
Nov 1, 2019

Conversation

sbrunner
Copy link
Member

@sbrunner sbrunner commented Oct 3, 2019 •
edited
Loading

Currently

      constants:
        gmfSearchActions: []

don't override

      dynamic_constants:
        gmfSearchGroups: fulltextsearch_groups

@sbrunner sbrunner added this to the 2.5 milestone Oct 3, 2019
@sbrunner sbrunner force-pushed the interface-override branch from e994c10 to 786f7c8 Compare October 3, 2019 09:51
@sbrunner sbrunner force-pushed the interface-override branch from 786f7c8 to 1ff4ecf Compare October 3, 2019 10:43
@sbrunner sbrunner marked this pull request as ready for review October 3, 2019 11:53
@camptocamp camptocamp deleted a comment Oct 3, 2019
@sbrunner sbrunner merged commit 915a538 into 2.4 Nov 1, 2019
@sbrunner sbrunner deleted the interface-override branch November 1, 2019 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fredj fredj fredj approved these changes

@arnaud-morvan arnaud-morvan arnaud-morvan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.5
Development

Successfully merging this pull request may close these issues.
3 participants
@sbrunner @fredj @arnaud-morvan