Be able to configure the cookie same site #5124
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pvalsecc
approved these changes
Jul 2, 2019
| from pyramid_multiauth import MultiAuthenticationPolicy | ||
|
|
||
| from c2cgeoportal_geoportal.resources import defaultgroupsfinder | ||
|
|
||
| LOG = logging.getLogger(__name__) |
| callback=defaultgroupsfinder, | ||
| cookie_name=settings["authtkt_cookie_name"], | ||
| samesite=samesite is None if samesite == '' else samesite, |
There was a problem hiding this comment.
samesite == '' => samesite is None == False
So it could be simplified to:
False if samesite == '' else samesite
There was a problem hiding this comment.
But False is not a correct value for samesite:
samesite
Default: 'Lax'. The 'samesite' option of the session cookie. Set the value to None to turn off the samesite option.
So it should be correct and really simpler with:
samesite=samesite or None
There was a problem hiding this comment.
Note: for boolean settings it would be better to use pyramid.settings.asbool
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.