Move the apihelp to the static folder and move the static folder to t… #5098
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbrunner
force-pushed
the
move-apihelp
branch
2 times, most recently
from
185d8ef to
e31bd8b
Compare
sbrunner
force-pushed
the
move-apihelp
branch
4 times, most recently
from
07f543c to
465bb55
Compare
fredj
reviewed
Jun 27, 2019
| @@ -54,7 +54,7 @@ def static_url(path, **kwargs): | |||
| request.static_url = static_url | |||
|
|
|||
| self.assertEqual(get_url2("test", "static://pr:st/icon.png", request, set()), "http://server.org/pr:st/icon.png") | |||
| self.assertEqual(get_url2("test", "static:///icon.png", request, set()), "http://server.org/my_project_geoportal:static/icon.png") | |||
| self.assertEqual(get_url2("test", "static:///icon.png", request, set()), "http://server.org//etc/geomapfish/static/icon.png") | |||
There was a problem hiding this comment.
Suggested change
| self.assertEqual(get_url2("test", "static:///icon.png", request, set()), "http://server.org//etc/geomapfish/static/icon.png") | |
| self.assertEqual(get_url2("test", "static:///icon.png", request, set()), "http://server.org/etc/geomapfish/static/icon.png") |
double slash in the url ?
There was a problem hiding this comment.
It's just an artifact of the tests...
There was a problem hiding this comment.
It should be like that or also changing the get static URL method ...
fredj
reviewed
Jun 27, 2019
| @@ -239,7 +239,7 @@ def static_url(url, **kwargs): | |||
| "time": "10:36:28", | |||
| "datetime": "2003-09-25T10:36:28", | |||
| "url1": "http://example.com/hi?a=b#c", | |||
| "url2": "http://dummy.org/tests_geoportal:static/path/icon.png", | |||
| "url2": "http://dummy.org//etc/geomapfish/static/path/icon.png", | |||
There was a problem hiding this comment.
Suggested change
| "url2": "http://dummy.org//etc/geomapfish/static/path/icon.png", | |
| "url2": "http://dummy.org/etc/geomapfish/static/path/icon.png", |
fredj
approved these changes
Jun 27, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…he config