[Qgis] Add group support, some fixies #3971
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pvalsecc
approved these changes
Aug 7, 2018
| @@ -36,7 +36,8 @@ def __init__(self, msg): | |||
| class GeoMapFishAccessControl(QgsAccessControlFilter): | |||
| """ Implements GeoMapFish access restriction """ | |||
|
|
|||
| EXPRESSION_TYPE = ["GPKG", "PostgreSQL database with PostGIS extension"] | |||
| SUBSETSTRING_TYPE = ["GPKG", "PostgreSQL database with PostGIS extension"] | |||
| LOCK = Lock() | |||
There was a problem hiding this comment.
Could be at instance level instead of class level
| return self.layers | ||
|
|
||
| project_file = self.server_iface.configFilePath() | ||
| project = QgsProject() |
There was a problem hiding this comment.
QgsProject.instance() and you can remove the read.
| for name in names: | ||
| groups[name].append(layer.name()) | ||
|
|
||
| new_names = [] + names |
| sort_keys=True, indent=4 | ||
| ) | ||
| )) | ||
| self.layers = layers |
There was a problem hiding this comment.
Not removed by invalidate...
There was a problem hiding this comment.
Should be done in another pull request
There was a problem hiding this comment.
But not using redis. There should be a way to subscribe to a signal that is triggered when the configuration is reloaded...
There was a problem hiding this comment.
Humpf, forgot about the GMF DB. For the QgsProjec signal: https://qgis.org/api/classQgsProject.html#a8b66ad18c789739bbd0ab9c16ab9dbe6
| for name in groups[group]: | ||
| if name not in layers: | ||
| layers[name] = [] | ||
| layers[name].append(layer) |
There was a problem hiding this comment.
layers.setdefault(name, []).append(layer)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.