Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove legacy documentation, cleanup #3833

Merged
merged 1 commit into from
Jun 18, 2018
Merged

Remove legacy documentation, cleanup #3833

merged 1 commit into from
Jun 18, 2018

Conversation

sbrunner
Copy link
Member

No description provided.

@sbrunner sbrunner added this to the 2.3 milestone Jun 18, 2018
@sbrunner sbrunner requested review from pvalsecc and jwkaltz June 18, 2018 12:10
layer, e.g.: 'name', used by
`FeaturesWindow <http://docs.camptocamp.net/cgxp/2.2/lib/plugins/FeaturesWindow.html>`_.
* ``Disclaimer``: optional, copyright of the layer.
* ``Identifier attribute field``: field used to identify a feature from the layer, e.g.: 'name'.
* ``Restrictions area``: the areas throw witch the user can see the layer.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

throw witch -> through which

(yes I know it is not part of the PR changes, but I am seeing it now :) )

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1, thanks

layer, e.g.: 'name', used by
`FeaturesWindow <http://docs.camptocamp.net/cgxp/2.2/lib/plugins/FeaturesWindow.html>`_.
* ``Disclaimer``: optional, copyright of the layer.
* ``Identifier attribute field``: field used to identify a feature from the layer, e.g.: 'name'.
* ``Restrictions area``: the areas throw witch the user can see the layer.

On ``internal WMS`` layer we have the following specific attributes:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

layer -> layers

@@ -88,13 +48,15 @@ Finally, your QGIS project layers CRS should all be in the same CSR. This is sub
change.

Connect to Postgres database
*****************************
****************************

This section is subject to change when the QGIS plugin is available.

The way you should connect QGIS to the database is based on an external file
called. pg_service.conf located in the home directory. The content of this file
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

called. pg_service.conf -> called pg_service.conf


This section is subject to change when the QGIS plugin is available.

The way you should connect QGIS to the database is based on an external file
called. pg_service.conf located in the home directory. The content of this file
is as follow::
is as follow:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is as follows:

@@ -117,19 +79,16 @@ You can have several sections. A section start with a name with [] and
finish with a blanck line. This file should be a unix file.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

blanck -> blank

@@ -117,19 +79,16 @@ You can have several sections. A section start with a name with [] and
finish with a blanck line. This file should be a unix file.

On QGIS desktop, when creating a new PostGIS connection, give it a name and use
the service name (`geomapfish` in our example) in the connection parameters
the service name (``geomapfish`` in our example) in the connection parameters
form.

Copy past this file in the server, change the parameters to fit with the server
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy past -> Copy-paste

@@ -9,11 +9,11 @@ Headers
By default most of the elements will be cached for 10 days by the browser.

To change this value for all the application change in the
``vars_<package>.yaml`` file the ``vars/default_max_age`` value. ``0`` will mean ``no-cache``.
``vars.yaml`` file the ``vars/default_max_age`` value. ``0`` will mean ``no-cache``.
The specified value is in seconds.

To change this value for a specific service add the following stricture in the
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

stricture -> structure

@@ -51,7 +51,7 @@ A ``docker-compose.yml.mako`` file is created as a starting point.

If you want to host the database on your local machine, you must add a
``dbhost`` and ``dbhost_slave`` entry pointing to ``172.17.0.1`` (your host address for Docker
container) in your ``vars_<package>.yaml`` file. Then you need to make sure
container) in your ``vars.yaml`` file. Then you need to make sure
Postgres is configured to listen on that interface and accepts authentication.

If you want to use an external serveur for the database, just put it is address
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

serveur -> server
it is address -> its address

@@ -97,6 +69,7 @@ generated by the templating. Then we should do:
This system works for print v2 but must be adapted for
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we remove this part (is print v2 considered deprecated?)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 thanks :-)

@@ -1,28 +0,0 @@
.. _build_doc:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are we removing this from our documentation? Or moving it elsewhere?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The documentation is build by Travis and has this own make rule, then for me it don't needs a specific (and probably unmaintained) documentation...

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's fine for me, but I think then you need to remove references to "build_doc", too

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For me it's done, do you see an other one?

@sbrunner sbrunner merged commit bb47317 into 2.3 Jun 18, 2018
@sbrunner sbrunner deleted the rm-floor-slider branch June 18, 2018 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants