Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Be able to get the local and s3 tile in Docker compose mode #3798

Merged
merged 3 commits into from
Jun 8, 2018

Conversation

sbrunner
Copy link
Member

@sbrunner sbrunner commented Jun 7, 2018

No description provided.

@sbrunner sbrunner added this to the 2.3 milestone Jun 7, 2018
@sbrunner sbrunner requested a review from pvalsecc June 7, 2018 09:43
@sbrunner sbrunner changed the title Tiles docker Be able to get the local and s3 tile in Docker compose mode Jun 7, 2018
@@ -65,7 +65,7 @@ Sphinx==1.7.2 # doc
sphinx-prompt==1.0.0 # doc
SQLAlchemy==1.2.6
tilecloud==0.5.1 # Tile generation
tilecloud-chain==1.5.2 # Tile generation
tilecloud-chain==1.6.0.dev1 # Tile generation
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Didn't you do a 1.6.0 release lately?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, not yet :-)

${service_defaults('mapserver', 80)}\
${service_defaults('tilecloudchain', 80)}\

tilecloudchain:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You have this key twice?!?!?

- config:ro
${service_defaults('tilecloudchain')}\
entrypoint:
- bash
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why using bash? And why the entrypoint instead of the command?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sleep isn't an executable, it's a bash command

@@ -57,7 +57,7 @@ backend geoportal


backend tilecloudchain
option httpchk GET ${VISIBLE_ENTRY_POINT}tiles HTTP/1.0\r\nUser-Agent:\ healthcheck
option httpchk GET ${VISIBLE_ENTRY_POINT}tiles/1.0.0/WMTSCapabilities.xml HTTP/1.0\r\nUser-Agent:\ healthcheck
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not using the c2c health check?

@@ -71,6 +71,8 @@ frontend plain
# If the path starts with /tiles/, use the tilecloudchain backend
acl is_tiles var(req.path) -m beg ${VISIBLE_ENTRY_POINT}tiles/
use_backend tilecloudchain if is_tiles
acl is_tiles var(req.path) -m beg ${VISIBLE_ENTRY_POINT}static_tiles/
use_backend tilecloudchain if is_tiles

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please define the env var C2C_BASE_PATH=/c2c_tiles and add the rule to the front

@sbrunner sbrunner force-pushed the tiles-docker branch 4 times, most recently from ea2ae82 to 5f54d0d Compare June 7, 2018 13:25
@sbrunner sbrunner force-pushed the tiles-docker branch 3 times, most recently from 0e63d6f to d71d8f5 Compare June 7, 2018 17:59
@sbrunner sbrunner merged commit fc2a2d2 into 2.3 Jun 8, 2018
@sbrunner sbrunner deleted the tiles-docker branch June 8, 2018 09:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants