Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix signal send for Gunicorn instead of for Apache #3794

Merged
merged 1 commit into from
Jun 6, 2018
Merged

Conversation

sbrunner
Copy link
Member

@sbrunner sbrunner commented Jun 6, 2018

No description provided.

@sbrunner sbrunner added this to the 2.3 milestone Jun 6, 2018
@sbrunner sbrunner requested a review from pvalsecc June 6, 2018 08:21
@@ -85,7 +85,7 @@ Edit a file in a running apache WSGI container

docker-compose exec geoportal bash
vi ...
kill -s USR1 1 # graceful
kill -s HUP `ps aux|grep gunicorn|head --lines=1|awk '{print $2}'` # graceful
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Then, the title is wrong...

Why don't you suggest to put gunicorn in devel mode (the --reload option) instead?

@@ -78,14 +78,20 @@ Actually we display the running rule and why she is running (dependence update).
Docker
------

Edit a file in a running apache WSGI container
Run gunicorn to reload on modified python file
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

... to reload on modifications of python files

..............................................

Add the following environement variable to the geoportal container:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

environment


``GUNICORN_PARAMS="-b :80 --worker-class gthread --threads 1 --workers 1 --reload"``

Gaceful the running geoportl container
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do a graceful restart of the running geoportal container

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, fixed :-)

@sbrunner sbrunner merged commit bf1ad1c into 2.3 Jun 6, 2018
@sbrunner sbrunner deleted the fix-debugginf branch June 6, 2018 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants