loaders.load_csv: allow relative paths w/ ODOO_DATA_PATH
#36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simahawk
force-pushed
the
odoo-data-path
branch
from
7f618df
to
ba1f83d
Compare
guewen
suggested changes
Mar 19, 2018
| :param model: Odoo model name or model klass from env | ||
| :param path: absolute or relative path to CSV file. | ||
| If a relative path is given you must provide a value for | ||
| `ODOO_DATA_PATH` in your environment |
There was a problem hiding this comment.
"or set the --odoo-data-path option"
anthem/cli.py
Outdated
| @@ -53,9 +57,21 @@ def main(): | |||
| 'configuration file and -d for the database name. Those must be at ' | |||
| 'the end of the arguments' | |||
| ) | |||
| parser.add_argument( | |||
| 'odoo-data-path', | |||
| nargs=argparse.REMAINDER, | |||
There was a problem hiding this comment.
REMAINDER is to take all the "unknown" remaining args, which will be passed down to odoo, only odoo-args should use it. This argument should probably only have action='store_true'action='store' (the default) and no nargs
simahawk
force-pushed
the
odoo-data-path
branch
from
ba1f83d
to
f2e13a3
Compare
|
Travis says: |
simahawk
force-pushed
the
odoo-data-path
branch
from
f2e13a3
to
b374115
Compare
|
@guewen damn, somehow I lost the |
simahawk
force-pushed
the
odoo-data-path
branch
from
b374115
to
f2cbbd6
Compare
guewen
approved these changes
Mar 19, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.