Defer Services_Json inclusion/initialization until really needed #91
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sserbin
force-pushed
the
defer-services-json-inclusion
branch
from
c1aad92
to
29d8e06
Compare
|
Tests pass on 5.6 and 7, other travis envs seem to be not working at all |
Alternatively, I'd consider dropping Services_Json altogether. Since php 5.2 php comes in with bundled json ext so it should be available everywhere
sserbin
force-pushed
the
defer-services-json-inclusion
branch
from
29d8e06
to
288adf3
Compare
rebased on master (which has updated travis config), so tests pass now |
|
Thanks for this, I'd agree that this serialiser should be dropped. Hopefully someone from CM can make that happen. In the interim this change makes sense. |
|
Thanks, @tobio |
|
@taledo @markstaples any chance we can get a release for this? 🙏 I know there hasn't been anything else merged into master since the past release, but would be great to have this released, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Alternatively, I'd consider dropping Services_Json altogether. Since php
5.2 php comes in with bundled json ext so it should be available everywhere.
The motivation for this is that
requireing this file always not only registers a class definition but also produces some undesired side-effects - namely, global constants definitions