Update sortFiles function #25
Conversation
|
Oh wow, seems like CI is failing for Node 10 due to the way the array sort parameter order was changed in Node.js 11: nodejs/node#24294 Looking into it... |
friederbluemle
force-pushed
the
update-files-sort
branch
from
0c88af8 to
0888dd2
Compare
|
@friederbluemle apologies for only seeing this PR now... I somehow completely missed or forgot about it. Looking now. |
|
Hey @cameronhunter - thanks for taking a look! It's been a while since I last checked this repo 😅 will have a look as soon as I'm in front of a computer 👍 |
|
Yeah, I've been slow on this repo. I've just rewritten it in TypeScript and released a new version. It looks like there are some conflicts with this PR as a result – apologies. |
friederbluemle
force-pushed
the
update-files-sort
branch
from
0888dd2 to
0e33bfb
Compare
There was a problem hiding this comment.
@cameronhunter - I've just rebased the branch and left two comments. Please check when you have time. Thanks!
|
Ooh, I guess I still need to update some of the tests that are broken now... |
friederbluemle
force-pushed
the
update-files-sort
branch
2 times, most recently
from
5b08cd3 to
8e8adf8
Compare
friederbluemle
force-pushed
the
update-files-sort
branch
from
8e8adf8 to
2aa5b6d
Compare
friederbluemle
force-pushed
the
update-files-sort
branch
from
2aa5b6d to
826aa17
Compare
|
Thanks for the contribution @friederbluemle! 🎉 |
|
Published as |
A couple of improvements to the way the
filesarray is sorted.It now places exclusions (starting with
!) last - Otherwise they have no effect. It will also put directories (ending in/) first, so it better reflects the defaultlsoutput with--group-directories-first.Fixes #24
I also added four new test cases for the
sortFilesfunction.