Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: memory sort without system message #1788

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

raywhoelse
Copy link
Collaborator

@raywhoelse raywhoelse commented Mar 11, 2025

Description

Fixes #1762

Checklist

Go over all the following points, and put an x in all the boxes that apply.

  • I have read the CONTRIBUTION guide (required)
  • I have linked this PR to an issue using the Development section on the right sidebar or by adding Fixes #issue-number in the PR description (required)
  • I have checked if any dependencies need to be added or updated in pyproject.toml and uv lock
  • I have updated the tests accordingly (required for a bug fix or a new feature)
  • I have updated the documentation if needed:
  • I have added examples if this is a new feature

If you are unsure about any of these, don't hesitate to ask. We are here to help!

@raywhoelse raywhoelse requested a review from Wendong-Fan March 11, 2025 01:32
@coolbeevip
Copy link
Collaborator

Can you add some test cases in test_score_based.py?

https://github.com/camel-ai/camel/blob/master/test/memories/context_creators/test_score_based.py

@raywhoelse raywhoelse requested a review from coolbeevip March 11, 2025 03:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] system prompt will be thrown away when ScoreBasedContextCreator sorts it
2 participants