Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Deepseek r1 reasoning content #1523

Merged
merged 2 commits into from
Jan 30, 2025
Merged

fix: Deepseek r1 reasoning content #1523

merged 2 commits into from
Jan 30, 2025

Conversation

Wendong-Fan
Copy link
Member

@Wendong-Fan Wendong-Fan commented Jan 29, 2025

Description

fix based on review comment: #1483 (review)

Motivation and Context

  • I have raised an issue to propose this change (required for new features and bug fixes)

Types of changes

What types of changes does your code introduce? Put an x in all the boxes that apply:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds core functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation (update in the documentation)
  • Example (update in the folder of example)

Implemented Tasks

  • Subtask 1
  • Subtask 2
  • Subtask 3

Checklist

Go over all the following points, and put an x in all the boxes that apply.
If you are unsure about any of these, don't hesitate to ask. We are here to help!

  • I have read the CONTRIBUTION guide. (required)
  • My change requires a change to the documentation.
  • I have updated the tests accordingly. (required for a bug fix or a new feature)
  • I have updated the documentation accordingly.

@Wendong-Fan Wendong-Fan marked this pull request as ready for review January 29, 2025 17:28
@Wendong-Fan Wendong-Fan self-assigned this Jan 29, 2025
@Wendong-Fan Wendong-Fan added the bug Something isn't working label Jan 29, 2025
@Wendong-Fan Wendong-Fan modified the milestones: Sprint 21, Sprint 22 Jan 29, 2025
@Wendong-Fan Wendong-Fan merged commit 1785f6f into master Jan 30, 2025
6 checks passed
@Wendong-Fan Wendong-Fan deleted the deepseek branch January 30, 2025 01:46
MuggleJinx pushed a commit that referenced this pull request Feb 4, 2025
apokryphosx pushed a commit that referenced this pull request Feb 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

2 participants