feat: structured loader #1395
Merged
feat: structured loader #1395
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
13 tasks
2 tasks
WHALEEYE
reviewed
Jan 10, 2025
Wendong-Fan
commented
Jan 10, 2025
…camel into feat/structured_loader
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
Asher-hss
pushed a commit
that referenced
this pull request
Jan 17, 2025
Co-authored-by: liuxukun2000 <xukunliu2025@u.northwestern.edu> Co-authored-by: Xukun Liu <57486241+liuxukun2000@users.noreply.github.com>
lightaime
reviewed
Jan 20, 2025
Comment on lines
+108
to
+120
| if isinstance(data, DataFrame): | ||
| return SmartDataframe(data, config=self.config) | ||
| file_path = str(data) | ||
| path = Path(file_path) | ||
| if not file_path.startswith("http") and not path.exists(): | ||
| raise FileNotFoundError(f"File {file_path} not found") | ||
| if path.suffix in self.__LOADER: | ||
| return SmartDataframe( | ||
| self.__LOADER[path.suffix](file_path, *args, **kwargs), # type: ignore[operator] | ||
| config=self.config, | ||
| ) | ||
| else: | ||
| raise ValueError(f"Unsupported file format: {path.suffix}") |
There was a problem hiding this comment.
I think the loader is made for agent. We are not expect to use LLM to ask questions here. If we do want to use a chat method. Should we have at least a wrapper chat method if we want to use SmartDataframe from pandasai or we can add it into toolkit?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Describe your changes in detail.
Motivation and Context
close #1325Types of changes
What types of changes does your code introduce? Put an
xin all the boxes that apply:Implemented Tasks
Checklist
Go over all the following points, and put an
xin all the boxes that apply.If you are unsure about any of these, don't hesitate to ask. We are here to help!