Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs:add o1datagene_cookbook #1359

Merged
merged 4 commits into from
Dec 27, 2024
Merged

docs:add o1datagene_cookbook #1359

merged 4 commits into from
Dec 27, 2024

Conversation

zjrwtx
Copy link
Collaborator

@zjrwtx zjrwtx commented Dec 24, 2024

Description

Describe your changes in detail.

Motivation and Context

Why is this change required? What problem does it solve?
If it fixes an open issue, please link to the issue here.
You can use the syntax close #15213 if this solves the issue #15213

  • I have raised an issue to propose this change (required for new features and bug fixes)

Types of changes

What types of changes does your code introduce? Put an x in all the boxes that apply:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds core functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation (update in the documentation)
  • Example (update in the folder of example)

Implemented Tasks

  • Subtask 1
  • Subtask 2
  • Subtask 3

Checklist

Go over all the following points, and put an x in all the boxes that apply.
If you are unsure about any of these, don't hesitate to ask. We are here to help!

  • I have read the CONTRIBUTION guide. (required)
  • My change requires a change to the documentation.
  • I have updated the tests accordingly. (required for a bug fix or a new feature)
  • I have updated the documentation accordingly.

@zjrwtx zjrwtx requested a review from Wendong-Fan December 24, 2024 14:00
@zjrwtx zjrwtx self-assigned this Dec 24, 2024
@Wendong-Fan Wendong-Fan added the documentation Improvements or additions to documentation label Dec 24, 2024
@Wendong-Fan Wendong-Fan added this to the Sprint 19 milestone Dec 24, 2024
@Wendong-Fan
Copy link
Member

@zjrwtx zjrwtx changed the title add o1datagene_cookbook docs:add o1datagene_cookbook Dec 25, 2024
@zjrwtx
Copy link
Collaborator Author

zjrwtx commented Dec 25, 2024

please refer to https://github.com/camel-ai/camel/blob/master/CONTRIBUTING.md#pull-request-item-stage, update the PR title

thanks!already change the pr title @Wendong-Fan

@zjrwtx zjrwtx added the Data Related to camel data processing label Dec 25, 2024
Copy link
Collaborator

@koch3092 koch3092 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @zjrwtx , left some comments below.

"id": "64e2b2cd"
},
"source": [
"### please prepare the qa data like below in json file:\n",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shall we need to prepare a simple sample file?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!already add it

"output_type": "stream",
"name": "stdout",
"text": [
"Enter your HuggingFace username: zjrwtxtechstudio\n",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's consider using a more general one, or putting a public account in the cookbook.

Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@Wendong-Fan Wendong-Fan merged commit 8d7aaa4 into master Dec 27, 2024
5 of 6 checks passed
@Wendong-Fan Wendong-Fan deleted the o1datagene_cookbook branch December 27, 2024 15:02
@Wendong-Fan
Copy link
Member

from Guohao:

  1. naming of the data generation method need to be check
  2. add more clear description for the methods used in the data gen

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Data Related to camel data processing documentation Improvements or additions to documentation
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

3 participants