Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Remove strict:ture for OpenAI.chat.completions.create #1344

Merged
merged 5 commits into from
Dec 18, 2024

Conversation

Wendong-Fan
Copy link
Member

@Wendong-Fan Wendong-Fan commented Dec 18, 2024

Description

strict:ture is required by OpenAI beta client, otherwise would have error:

ValueError: `add` is not strict. Only `strict` function tools can be auto-parsed

but if adding strict:ture to OpenAI chat client, for some cases would get error:

openai.BadRequestError: Error code: 400 - {'error': {'message': "Invalid schema for function 'tsp_dynamic_programming': In context=(), 'required' is required to be supplied and to be an array including every key in properties. Extra required key 'input_dataa' supplied.", 'type': 'invalid_request_error', 'param': 'tools[0].function.parameters', 'code': 'invalid_function_parameters'}}

Motivation and Context

Why is this change required? What problem does it solve?
If it fixes an open issue, please link to the issue here.
You can use the syntax close #15213 if this solves the issue #15213

  • I have raised an issue to propose this change (required for new features and bug fixes)

Types of changes

What types of changes does your code introduce? Put an x in all the boxes that apply:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds core functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation (update in the documentation)
  • Example (update in the folder of example)

Implemented Tasks

  • Subtask 1
  • Subtask 2
  • Subtask 3

Checklist

Go over all the following points, and put an x in all the boxes that apply.
If you are unsure about any of these, don't hesitate to ask. We are here to help!

  • I have read the CONTRIBUTION guide. (required)
  • My change requires a change to the documentation.
  • I have updated the tests accordingly. (required for a bug fix or a new feature)
  • I have updated the documentation accordingly.

@Wendong-Fan Wendong-Fan self-assigned this Dec 18, 2024
@Wendong-Fan Wendong-Fan marked this pull request as ready for review December 18, 2024 15:58
@Wendong-Fan Wendong-Fan merged commit 65420f1 into master Dec 18, 2024
5 of 6 checks passed
@Wendong-Fan Wendong-Fan deleted the tool_schema_update branch December 18, 2024 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

1 participant