Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: sglang doc, logger setting, version release #1317

Merged
merged 5 commits into from
Jan 2, 2025
Merged

Conversation

NeilJohnson0930
Copy link
Collaborator

@NeilJohnson0930 NeilJohnson0930 commented Dec 13, 2024

Description

add model speed test between sglang and vllm
update logger setting
release v 0.2.15

Motivation and Context

Why is this change required? What problem does it solve?
If it fixes an open issue, please link to the issue here.
You can use the syntax close #15213 if this solves the issue #15213

  • I have raised an issue to propose this change (required for new features and bug fixes)

Types of changes

What types of changes does your code introduce? Put an x in all the boxes that apply:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds core functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation (update in the documentation)
  • Example (update in the folder of example)

Implemented Tasks

  • Subtask 1
  • Subtask 2
  • Subtask 3

Checklist

Go over all the following points, and put an x in all the boxes that apply.
If you are unsure about any of these, don't hesitate to ask. We are here to help!

  • I have read the CONTRIBUTION guide. (required)
  • My change requires a change to the documentation.
  • I have updated the tests accordingly. (required for a bug fix or a new feature)
  • I have updated the documentation accordingly.

Copy link
Member

@Wendong-Fan Wendong-Fan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @NeilJohnson0930 !

could you add

  1. sglang to our model list https://docs.camel-ai.org/key_modules/models.html#supported-model-platforms
  2. sglang setup/guideline as new part 4.3 under https://docs.camel-ai.org/key_modules/models.html#using-on-device-open-source-models
  3. sglang model speed conclusion to https://docs.camel-ai.org/key_modules/models.html#about-model-speed

we don't need to add the speed test code to camel's core module, add the content to doc part is more suitable, thanks!

@Wendong-Fan Wendong-Fan changed the title feat: add model speed test between sglang and vllm docs: add model speed test between sglang and vllm Jan 2, 2025
@Wendong-Fan Wendong-Fan added the documentation Improvements or additions to documentation label Jan 2, 2025
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@Wendong-Fan Wendong-Fan changed the title docs: add model speed test between sglang and vllm chore: sglang doc, logger setting, version release Jan 2, 2025
@Wendong-Fan Wendong-Fan merged commit 0d5071b into master Jan 2, 2025
6 checks passed
@Wendong-Fan Wendong-Fan deleted the dev_master branch January 2, 2025 07:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

2 participants