Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: outdated code snippets for loaders module in doc #1310

Merged
merged 1 commit into from
Dec 12, 2024

Conversation

WHALEEYE
Copy link
Collaborator

Description

Updated the docs for loaders module. Also moved the static method in the Base IO file into module-level to improve the code quality.

@WHALEEYE WHALEEYE added the bug Something isn't working label Dec 12, 2024
@WHALEEYE WHALEEYE requested a review from Wendong-Fan December 12, 2024 02:47
@WHALEEYE WHALEEYE self-assigned this Dec 12, 2024
@Wendong-Fan Wendong-Fan added this to the Sprint 18 milestone Dec 12, 2024
Copy link
Member

@Wendong-Fan Wendong-Fan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @WHALEEYE ! LGTM

@Wendong-Fan Wendong-Fan merged commit 99aedcd into master Dec 12, 2024
6 checks passed
@Wendong-Fan Wendong-Fan deleted the docs/fix/loaders branch December 12, 2024 06:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

[BUG] The loaders module in the document has a lot of examples that have expired and cannot be used properly.
2 participants