Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: that user cannot see question when using human_toolkit #1251

Merged
merged 1 commit into from
Nov 30, 2024

Conversation

MuggleJinx
Copy link
Collaborator

@MuggleJinx MuggleJinx commented Nov 29, 2024

Motivation and Context

Currently, when calling ask_human_via_console, the question will not appear in console, causing difficulty for the user. Because the logger.info() cannot be shown in the console.

Types of changes

What types of changes does your code introduce? Put an x in all the boxes that apply:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds core functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation (update in the documentation)
  • Example (update in the folder of example)

Checklist

Go over all the following points, and put an x in all the boxes that apply.
If you are unsure about any of these, don't hesitate to ask. We are here to help!

  • I have read the CONTRIBUTION guide. (required)
  • My change requires a change to the documentation.
  • I have updated the tests accordingly. (required for a bug fix or a new feature)
  • I have updated the documentation accordingly.

@Wendong-Fan Wendong-Fan changed the title fix: fix that user cannot see question when using human_toolkit fix that user cannot see question when using human_toolkit Nov 29, 2024
@Wendong-Fan Wendong-Fan added the bug Something isn't working label Nov 30, 2024
@Wendong-Fan Wendong-Fan changed the title fix that user cannot see question when using human_toolkit fix: that user cannot see question when using human_toolkit Nov 30, 2024
@Wendong-Fan Wendong-Fan added this to the Sprint 17 milestone Nov 30, 2024
Copy link
Member

@Wendong-Fan Wendong-Fan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @MuggleJinx , LGTM

@Wendong-Fan Wendong-Fan merged commit 78477d4 into master Nov 30, 2024
4 of 6 checks passed
@Wendong-Fan Wendong-Fan deleted the human_as_tool_small_fix branch November 30, 2024 19:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

2 participants