Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Integrate Brave Web Search API in search toolkit (#1005) #1234

Merged
merged 5 commits into from
Dec 5, 2024

Conversation

MuggleJinx
Copy link
Collaborator

Description

Brave Web Search API is a REST API to query Brave Search and get back search results from the web.
This PR enhance the search toolkit with the Brave Web Search API.

Motivation and Context

Closes issue #1005.

Types of changes

What types of changes does your code introduce? Put an x in all the boxes that apply:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds core functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation (update in the documentation)
  • Example (update in the folder of example)

Implemented Tasks

  • Add one new model type in Gemini model series.
  • Edit the corresponding example, and test file.

Checklist

Go over all the following points, and put an x in all the boxes that apply.
If you are unsure about any of these, don't hesitate to ask. We are here to help!

  • I have read the CONTRIBUTION guide. (required)
  • My change requires a change to the documentation.
  • I have updated the tests accordingly. (required for a bug fix or a new feature)
  • I have updated the documentation accordingly.

@Wendong-Fan Wendong-Fan added this to the Sprint 17 milestone Nov 30, 2024
@Wendong-Fan Wendong-Fan linked an issue Nov 30, 2024 that may be closed by this pull request
2 tasks
@liuxukun2000
Copy link
Collaborator

Hi @MuggleJinx! Thank you for your contribution! Could you please add a comment at the end of the example file to indicate the expected output for this example? You can refer to the other examples for guidance. Thanks!

Copy link
Member

@Wendong-Fan Wendong-Fan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @MuggleJinx ! Overall LGTM, some minor change required

camel/toolkits/search_toolkit.py Outdated Show resolved Hide resolved
examples/toolkits/search_toolkit.py Outdated Show resolved Hide resolved
camel/toolkits/search_toolkit.py Outdated Show resolved Hide resolved
@Wendong-Fan Wendong-Fan merged commit a810b6c into master Dec 5, 2024
5 of 6 checks passed
@Wendong-Fan Wendong-Fan deleted the brave-api branch December 5, 2024 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

[Feature Request] Integrate Brave Web Search API
3 participants