Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add support for Gemini-Exp-1114 model (#1187) #1189

Merged
merged 1 commit into from
Nov 19, 2024

Conversation

MuggleJinx
Copy link
Collaborator

Description

This PR adds the newest Gemini-Exp-114 model, which is an experimental model from Google Gemini.

Motivation and Context

Closes issue #1187.

Types of changes

What types of changes does your code introduce? Put an x in all the boxes that apply:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds core functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation (update in the documentation)
  • Example (update in the folder of example)

Implemented Tasks

  • Add one new model type in Gemini model series.
  • Edit the corresponding example, and test file.

Checklist

Go over all the following points, and put an x in all the boxes that apply.
If you are unsure about any of these, don't hesitate to ask. We are here to help!

  • I have read the CONTRIBUTION guide. (required)
  • My change requires a change to the documentation.
  • I have updated the tests accordingly. (required for a bug fix or a new feature)
  • I have updated the documentation accordingly.

@CaelumF CaelumF self-requested a review November 18, 2024 15:16
@CaelumF CaelumF self-assigned this Nov 18, 2024
Copy link
Collaborator

@CaelumF CaelumF left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, works for me.

Worth noting the experimental models page says that the models can be removed at any time, do you think this warrants some sort of warning or notice from our end too @Wendong-Fan ?

@Wendong-Fan Wendong-Fan merged commit d4e2356 into master Nov 19, 2024
6 checks passed
@Wendong-Fan Wendong-Fan deleted the add-gemini-exp-1114 branch November 19, 2024 14:32
@Wendong-Fan Wendong-Fan added the Model Related to backend models label Nov 19, 2024
@Wendong-Fan Wendong-Fan added this to the Sprint 17 milestone Nov 19, 2024
@Wendong-Fan Wendong-Fan linked an issue Nov 19, 2024 that may be closed by this pull request
2 tasks
@Wendong-Fan Wendong-Fan assigned MuggleJinx and unassigned CaelumF Nov 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Model Related to backend models
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

[Feature Request] Support Gemini-Exp-1114
3 participants